Repository navigation
Create Storybook's settings directory in the Playwright image - #5629
Merged
Merged
Conversation
Storybook 8.6 writes a global settings file to `$HOME/.storybook/`. The Playwright container runs as the host user id with no home directory, so `$HOME` resolves to `/` and the write fails with EACCES, which aborts the Storybook dev server before Playwright can connect. Pre-create the directory the same way the image already does for the corepack and dlx caches. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
Latest k6 run output1Footnotes
|
Storybook 8.6 asks on first start whether to send anonymous crash reports, unless telemetry is disabled or `CI` is set. The Playwright container has neither, and the prompt blocks the Storybook server until Playwright gives up waiting for it. Disabling telemetry skips the prompt and the settings lookup behind it. Verified locally with `pnpm test:storybook` on Storybook 8.6.17: all 317 Storybook tests pass with this and the settings directory change. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
|
Full-stack documentation: https://docs.openverse.org/_preview/5629 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Unblocks #5539.
Description
Storybook 8.6 writes a global settings file to
$HOME/.storybook/settings.json. The Playwright container runs as the host user id with no matching home directory, so$HOMEresolves to/and the write fails:That aborts the Storybook server before Playwright can connect, which is why the Storybook job fails on #5539. This pre-creates the directory with open permissions, the same way
Dockerfile.playwrightalready handles the corepack and dlx cache folders.Storybook 8.6 also prompts on first start whether to send anonymous crash reports, unless telemetry is disabled or
CIis set in the environment. Neither is true inside the Playwright container, and the prompt blocks the server until Playwright's five-minute wait expires. The second commit disables telemetry in.storybook/main.ts, which skips the prompt.Verified locally by running
pnpm test:storybookon the #5539 branch with both changes: all 317 Storybook tests pass. With only the directory change, the run hangs on the prompt.Testing Instructions
After merge, tick the rebase checkbox for #5539 in #255. The "Run Playwright tests (storybook)" job should pass.
Checklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-propsfor the catalog or
ov just api/generate-docsfor the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin
🤖 Generated with Claude Code