Skip to content

Create Storybook's settings directory in the Playwright image - #5629

Merged
obenland merged 2 commits into
mainfrom
fix/playwright-storybook-settings-dir
Oct 13, 2026
Merged

obenland merged 2 commits into
mainfrom
fix/playwright-storybook-settings-dir

Conversation

@obenland

@obenland obenland commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Fixes

Unblocks #5539.

Description

Storybook 8.6 writes a global settings file to $HOME/.storybook/settings.json. The Playwright container runs as the host user id with no matching home directory, so $HOME resolves to / and the write fails:

SB_CORE-SERVER_0001 (SavingGlobalSettingsFileError): Unable to save global settings file to /.storybook/settings.json
Reason: Error: EACCES: permission denied, mkdir '/.storybook'

That aborts the Storybook server before Playwright can connect, which is why the Storybook job fails on #5539. This pre-creates the directory with open permissions, the same way Dockerfile.playwright already handles the corepack and dlx cache folders.

Storybook 8.6 also prompts on first start whether to send anonymous crash reports, unless telemetry is disabled or CI is set in the environment. Neither is true inside the Playwright container, and the prompt blocks the server until Playwright's five-minute wait expires. The second commit disables telemetry in .storybook/main.ts, which skips the prompt.

Verified locally by running pnpm test:storybook on the #5539 branch with both changes: all 317 Storybook tests pass. With only the directory change, the run hangs on the prompt.

Testing Instructions

After merge, tick the rebase checkbox for #5539 in #255. The "Run Playwright tests (storybook)" job should pass.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

🤖 Generated with Claude Code

Storybook 8.6 writes a global settings file to `$HOME/.storybook/`. The
Playwright container runs as the host user id with no home directory, so
`$HOME` resolves to `/` and the write fails with EACCES, which aborts the
Storybook dev server before Playwright can connect. Pre-create the
directory the same way the image already does for the corepack and dlx
caches.

Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 13, 2026 13:55
@obenland
obenland requested a review from a team as a code owner October 13, 2026 13:55
@obenland obenland added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: frontend Related to the Nuxt frontend labels Oct 13, 2026
@obenland
obenland requested review from dhruvkb and obulat October 13, 2026 13:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@openverse-bot openverse-bot moved this to 👀 Needs Review in Openverse PRs Oct 13, 2026
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 416      ✗ 0   
     data_received..................: 97 MB   401 kB/s
     data_sent......................: 132 kB  549 B/s
     http_req_blocked...............: avg=91.01µs  min=2.19µs   med=4.65µs   max=2.89ms   p(90)=188.38µs p(95)=364.94µs
     http_req_connecting............: avg=74.45µs  min=0s       med=0s       max=2.86ms   p(90)=103.64µs p(95)=305.04µs
     http_req_duration..............: avg=146.13ms min=17.81ms  med=91.02ms  max=917.27ms p(90)=345.13ms p(95)=426.1ms 
       { expected_response:true }...: avg=146.13ms min=17.81ms  med=91.02ms  max=917.27ms p(90)=345.13ms p(95)=426.1ms 
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 416 
     http_req_receiving.............: avg=161.05µs min=39.62µs  med=146.08µs max=453.96µs p(90)=254.48µs p(95)=292.79µs
     http_req_sending...............: avg=33.19µs  min=7.16µs   med=21.7µs   max=1.57ms   p(90)=39.68µs  p(95)=61.58µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=145.94ms min=17.68ms  med=90.88ms  max=916.89ms p(90)=344.93ms p(95)=425.9ms 
     http_reqs......................: 416     1.725709/s
     iteration_duration.............: avg=786.13ms min=230.43ms med=828.09ms max=1.6s     p(90)=1.07s    p(95)=1.1s    
     iterations.....................: 78      0.32357/s
     vus............................: 3       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR ↩

Storybook 8.6 asks on first start whether to send anonymous crash
reports, unless telemetry is disabled or `CI` is set. The Playwright
container has neither, and the prompt blocks the Storybook server until
Playwright gives up waiting for it. Disabling telemetry skips the prompt
and the settings lookup behind it.

Verified locally with `pnpm test:storybook` on Storybook 8.6.17: all 317
Storybook tests pass with this and the settings directory change.

Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
@openverse-bot openverse-bot added the 🧱 stack: documentation Related to Sphinx documentation label Oct 13, 2026
@github-actions

Copy link
Copy Markdown

Full-stack documentation: https://docs.openverse.org/_preview/5629

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@obenland
obenland merged commit 525832e into main Oct 13, 2026
53 checks passed
@obenland
obenland deleted the fix/playwright-storybook-settings-dir branch October 13, 2026 14:32
@github-project-automation github-project-automation Bot moved this from 👀 Needs Review to 🤝 Merged in Openverse PRs Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants