Skip to content

Pin CI tooling to restore build, lint, and image loading #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obenland merged 6 commits into from
Aug 25, 2026
Merged

Pin CI tooling to restore build, lint, and image loading #5602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a58e2be
Pin pipenv so the ingestion_server image builds again
ekamran Aug 20, 2026
a0ba10a
Pin @actions/artifact so the load-img action can require it
ekamran Aug 24, 2026
3be2e0a
Pin the API image's Debian release to bookworm
obenland Aug 25, 2026
b66d85e
Pin MinIO images and use `mc alias set`
obenland Aug 25, 2026
0932b16
Bump corepack to 0.35.0 for current npm signing keys
obenland Aug 25, 2026
fcbb80d
Slim the pipenv pin comment to its essence
obenland Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/load-img/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ runs:
- name: Install `@actions/artifact`
shell: bash
run: |
pnpm install @actions/artifact -w
# Pinned: v6 is ESM-only and its exports map has no CommonJS entry, so
# the `require()` in the script below fails with ERR_PACKAGE_PATH_NOT_EXPORTED.
pnpm install @actions/artifact@5.0.3 -w

- name: Download images
uses: actions/github-script@v7
Expand Down
5 changes: 3 additions & 2 deletions .github/actions/setup-env/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ runs:
- name: Setup pnpm
if: inputs.setup_nodejs == 'true'
shell: bash
# Fix for https://github.com/nodejs/corepack/issues/612
run: npm install -g corepack@0.31.0 && corepack enable pnpm
# Pinned so pnpm downloads are verified with current npm registry
# signing keys (https://github.com/nodejs/corepack/issues/612).
run: npm install -g corepack@0.35.0 && corepack enable pnpm

- name: Setup Node.js
if: inputs.setup_nodejs == 'true'
Expand Down
6 changes: 4 additions & 2 deletions api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ ARG API_PY_VERSION
# Python builder #
##################

FROM docker.io/python:${API_PY_VERSION} AS builder
# Pin the Debian release: the audiowaveform .deb below is built for
# Debian 12 (bookworm) and silently fails to install on newer releases.
FROM docker.io/python:${API_PY_VERSION}-bookworm AS builder

# Get the version from the main justfile
ARG OV_PDM_VERSION
Expand Down Expand Up @@ -45,7 +47,7 @@ RUN pdm install --check --frozen-lockfile $PDM_INSTALL_ARGS
# API #
#######

FROM docker.io/python:${API_PY_VERSION}-slim AS api
FROM docker.io/python:${API_PY_VERSION}-slim-bookworm AS api

LABEL org.opencontainers.image.source="https://github.com/WordPress/openverse"

Expand Down
4 changes: 2 additions & 2 deletions catalog/compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ services:
profiles:
- catalog_dependencies
- catalog
image: docker.io/minio/minio:latest
image: docker.io/minio/minio:RELEASE.2025-09-07T16-13-09Z
ports:
- "5010:5000"
- "5011:5001"
Expand All @@ -86,7 +86,7 @@ services:
profiles:
- catalog_dependencies
- catalog
image: docker.io/minio/mc:latest
image: docker.io/minio/mc:RELEASE.2025-08-13T08-35-41Z
env_file:
- .env
- ../docker/minio/.env
Expand Down
2 changes: 1 addition & 1 deletion docker/minio/load_to_s3_entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ set -euxo pipefail
# Wait for minio to be ready
sleep 5

/usr/bin/mc config host add s3 http://s3:5000 "${MINIO_ROOT_USER}" "${MINIO_ROOT_PASSWORD}"
/usr/bin/mc alias set s3 http://s3:5000 "${MINIO_ROOT_USER}" "${MINIO_ROOT_PASSWORD}"
cd /data
for b in */; do
echo "Loading bucket $b"
Expand Down
3 changes: 2 additions & 1 deletion ingestion_server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ RUN apt-get update \
&& apt-get autoremove -y \
&& rm -rf /var/lib/apt/lists/* \
&& python -m venv /venv \
&& pip install --upgrade pipenv
# pipenv >= 2026.4.0 rejects the existing Pipfile.lock hash (see #4658)
&& pip install pipenv==2026.2.2

# Copy the Pipenv files into the container
COPY Pipfile Pipfile.lock /
Expand Down
Loading