Skip to content

Update Nuxt and related dependencies to v3.13.0#4807

Merged
obulat merged 2 commits intomainfrom
chore-frontend-nuxt-v3.13
Aug 27, 2024
Merged

Update Nuxt and related dependencies to v3.13.0#4807
obulat merged 2 commits intomainfrom
chore-frontend-nuxt-v3.13

Conversation

@zackkrida
Copy link
Copy Markdown
Member

@zackkrida zackkrida commented Aug 26, 2024

Description

This PR updates Nuxt to the latest minor version. I tried using their reccommended ov pnpx nuxi@latest upgrade --force command to do the upgrade, but I had to update the version in our package.json first before the subdependencies would be updated in the lock file.

This PR also makes a change to locales, renaming the iso field to language, in preparation of v9 of Nuxt-i18n: https://i18n.nuxtjs.org/docs/v9/guide/breaking-changes-in-v9#locale-iso-renamed-to-language

Testing Instructions

All the things should work. CI should pass, and a local frontend clickthrough should not show any issues.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner August 26, 2024 15:09
@zackkrida zackkrida requested review from dhruvkb and obulat August 26, 2024 15:09
@openverse-bot openverse-bot added 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 26, 2024
@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🧱 stack: documentation Related to Sphinx documentation labels Aug 26, 2024
@zackkrida zackkrida force-pushed the chore-frontend-nuxt-v3.13 branch from a4061cb to 2e79f38 Compare August 26, 2024 15:13
@zackkrida zackkrida added the 🧰 goal: internal improvement Improvement that benefits maintainers, not users label Aug 26, 2024
@obulat
Copy link
Copy Markdown
Contributor

obulat commented Aug 26, 2024

The snapshots look identical to me 😕

@zackkrida zackkrida force-pushed the chore-frontend-nuxt-v3.13 branch from 82afdc2 to 8c3d74c Compare August 26, 2024 17:27
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 26, 2024

Full-stack documentation: https://docs.openverse.org/_preview/4807

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@zackkrida
Copy link
Copy Markdown
Member Author

zackkrida commented Aug 26, 2024

@obulat I replaced the error snapshot, the original seemed to have an extra 1px of whitespace on the left side!

sarayourfriend
sarayourfriend approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sarayourfriend sarayourfriend left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and great! This includes an update to @nuxtjs/robots that fixes its robots rule parsing and should allow us to add query-param based rules, so crawlers know they don't need to land on the tag and creator collection pages, which should reduce some of the load we've seen to search.

@obulat obulat merged commit d64a1e2 into main Aug 27, 2024
@obulat obulat deleted the chore-frontend-nuxt-v3.13 branch August 27, 2024 06:23
@sarayourfriend
Copy link
Copy Markdown
Collaborator

sarayourfriend commented Aug 27, 2024

BTW: I tried to play around with the robots settings, but I wasn't sure if it would end up breaking some bots. Slack and Twitter bot both ignore robots.txt to get embeds information, but apparently Discord's bot does not. It's hard to find comprehensive information about this, but I think to really resolve the issue we'd need to take a holistic look at our SEO goals and get input from someone more familiar with this stuff. On the other hand, the updates to the robots module are working great, so when/if we choose to make changes there, we'll have a great degree of flexibility now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@obulat obulat Awaiting requested review from obulat obulat is a code owner automatically assigned from WordPress/openverse-frontend

@dhruvkb dhruvkb Awaiting requested review from dhruvkb dhruvkb is a code owner automatically assigned from WordPress/openverse-frontend

Assignees

No one assigned

Labels

💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Projects

Openverse PRs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zackkrida @obulat @sarayourfriend @openverse-bot