Repository navigation
Follow the WordPress CSS coding standards in style.css - #162
Merged
MaggieCabrera merged 1 commit intoOct 21, 2026
Merged
Conversation
Puts each selector on its own line, adds the missing semicolon after `text-underline-offset`, and aligns a comment's closing `*/` with the others. Drops `!important` from the header and footer `margin-block-start: 0` rule. The block gap margin comes from `:where(.wp-site-blocks) > *`, which has zero specificity, so the rule already wins without it on the front end and in the Site Editor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
Bot
added
the
[Area] Global Styles
MaggieCabrera
approved these changes
Oct 21, 2026
MaggieCabrera
added a commit
to MaggieCabrera/wordpress-develop
that referenced
this pull request
Oct 21, 2026
Each selector in a list goes on its own line, the link underline rule gets its missing semicolon, and the more block comment closes like the others. The header and footer `margin-block-start: 0` rule drops `!important`, because its selector already beats the root block gap rules on the front end and in the editor. Synced from WordPress/ipsum#162. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings
style.cssin line with the WordPress CSS coding standards. stylelint does not flag these, so they passednpm run lint:css.text-wraprule and the link underline rule.text-underline-offset: 0.1em.*/of the "more block" comment with the other comments.!importantfrom the header and footermargin-block-start: 0rule. The standard asks for each!importantto be explained. This one has no effect, so I removed it instead.The block gap margin comes from
:where(.wp-site-blocks) > *.:where()has zero specificity, soheader.wp-block-template-partandfooter.wp-block-template-partalready win without!important.There is no open issue for this change.
Screenshots
None. The change has no visible effect.
Testing Instructions
I tested on WordPress 7.1.3 in wp-env, with the Gutenberg plugin inactive.
npm run lint:cssand confirm it passes.margin-block-start: 0px.I measured these with a headless browser, and all were 0px. In the Site Editor I also removed the rule completely, and the footer then got a 26px margin. So the rule is still needed, but
!importantis not.I did not check a color variation, because the change does not touch colors.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Finding the issues, writing the fix and running the margin checks; I reviewed the changes.
🤖 Generated with Claude Code