Skip to content

Name repeated landmarks and fix heading levels in patterns - #148

Merged
juanfra merged 1 commit into
trunkfrom
claude/brave-diffie-15b0de
Oct 13, 2026
Merged

juanfra merged 1 commit into
trunkfrom
claude/brave-diffie-15b0de

Conversation

@MaggieCabrera

Copy link
Copy Markdown
Contributor

Description

Part of #44, fixes #48.

Repeated landmarks now have unique names, and headings no longer skip a level or add a second h1 to the page. #48's template fixes still hold. This covers what they didn't reach: the archive sidebar template, the hero headers and a few patterns, old and new.

  • The Search block has no ariaLabel support, so functions.php turns on core's for it. The search forms are named "Site", "Menu" (overlay) and "Posts" (CTA Search), and the overlay navigations "Expanded". functions.php also declares navigation-widgets support, which the landmark guideline checks for.
  • Text Statement is now a paragraph, like Text Statement Wide, since it's a styled statement rather than a heading.
  • The default footers still have no heading, like the default themes' footers. The guideline asks for one unless the footer is a named landmark, so I'd like a second opinion on whether a one-line footer needs it.

Screenshots

No visual changes, except one: in After Hours, Text Statement now uses the body font instead of the condensed heading font, so it wraps one line longer.

Testing Instructions

  1. Import the accessibility test content and check the home page, a post, a page, an archive, search results and the 404 with a landmarks tool and HeadingsMap. Each has one banner, main and contentinfo, a single h1 and no skipped levels, and the search form is named "Site".
  2. In the Site Editor, swap the header for Hero Colophon or Hero Epigraph. The page still has a single h1, and the header navigation is "Primary".
  3. Swap the navigation overlay for Overlay Contents and open the menu on a small screen. Its navigation is "Expanded" and its search is "Menu".
  4. Add CTA Search, Archive Simple, Archive Photographic, Format Audio and Text Alternating to a page. Headings go from h1 to h2 without skipping, and the CTA's search is "Posts".
  5. Repeat a few steps in another color variation, and open the changed templates and patterns in the Site Editor. There are no block recovery warnings.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Auditing the theme against the landmark and heading guidelines, making the changes and testing them. I reviewed and adjusted the result.

🤖 Generated with Claude Code

Search forms and the overlay and hero navigation now have unique
names, so screen reader users can tell repeated landmarks apart. The
Search block has no ariaLabel support, so functions.php turns on
core's for it, and the theme declares navigation-widgets support.

Headings no longer jump from h1 to h3 in the archive sidebar template
and four patterns, the hero headers no longer add a second h1, Archive
Lead's post titles sit under its label, and Text Statement is a
paragraph, since it's a styled statement rather than a heading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added [Area] Patterns Issues or PRs that touch the theme's block patterns. [Area] Theme Functions Issues or PRs that touch functions.php. labels Oct 8, 2026

@juanfra juanfra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@juanfra
juanfra merged commit 46c0281 into trunk Oct 13, 2026
8 checks passed
@juanfra
juanfra deleted the claude/brave-diffie-15b0de branch October 13, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Patterns Issues or PRs that touch the theme's block patterns. [Area] Theme Functions Issues or PRs that touch functions.php.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect heading level order

2 participants