Repository navigation
Name repeated landmarks and fix heading levels in patterns - #148
Merged
Merged
Conversation
Search forms and the overlay and hero navigation now have unique names, so screen reader users can tell repeated landmarks apart. The Search block has no ariaLabel support, so functions.php turns on core's for it, and the theme declares navigation-widgets support. Headings no longer jump from h1 to h3 in the archive sidebar template and four patterns, the hero headers no longer add a second h1, Archive Lead's post titles sit under its label, and Text Statement is a paragraph, since it's a styled statement rather than a heading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #44, fixes #48.
Repeated landmarks now have unique names, and headings no longer skip a level or add a second h1 to the page. #48's template fixes still hold. This covers what they didn't reach: the archive sidebar template, the hero headers and a few patterns, old and new.
functions.phpturns on core's for it. The search forms are named "Site", "Menu" (overlay) and "Posts" (CTA Search), and the overlay navigations "Expanded".functions.phpalso declaresnavigation-widgetssupport, which the landmark guideline checks for.Screenshots
No visual changes, except one: in After Hours, Text Statement now uses the body font instead of the condensed heading font, so it wraps one line longer.
Testing Instructions
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Auditing the theme against the landmark and heading guidelines, making the changes and testing them. I reviewed and adjusted the result.
🤖 Generated with Claude Code