Skip to content

Use typography.textAlign for the pullquote's default alignment - #124

Merged
juanfra merged 2 commits into
trunkfrom
claude/trusting-burnell-94ee29
Oct 8, 2026
Merged

juanfra merged 2 commits into
trunkfrom
claude/trusting-burnell-94ee29

Conversation

@MaggieCabrera

Copy link
Copy Markdown
Contributor

Description

Moves the pullquote's default left alignment from its custom css string to typography.textAlign in theme.json. Pullquotes look the same, but Styles › Blocks › Pullquote now shows left as the default, and picking another alignment there works. Before, the custom CSS overrode it.

Testing Instructions

  1. Add a pullquote to a post. It's left aligned on the front end and in the editor.
  2. Set another pullquote to center or right from the block toolbar. It follows that alignment.
  3. Go to Styles › Blocks › Pullquote. Text alignment shows left selected.
  4. Pick Center there. Pullquotes without their own alignment are now centered. On trunk, nothing changes.
  5. Repeat with a color variation such as After Hours.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Making the change and testing it in a local environment.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the [Area] Global Styles Issues or PRs that touch theme.json or the base stylesheet. label Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maggie!

I'm wondering if, for RTL, we should use start or have an override in the stylesheet? Thoughts?

Follows the reading direction, so pullquotes align right on RTL sites.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaggieCabrera

Copy link
Copy Markdown
Contributor Author

Thanks Maggie!

I'm wondering if, for RTL, we should use start or have an override in the stylesheet? Thoughts?

You are right, done!

@juanfra juanfra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaggieCabrera 🚀

@juanfra
juanfra merged commit 0903e6a into trunk Oct 8, 2026
6 checks passed
@juanfra
juanfra deleted the claude/trusting-burnell-94ee29 branch October 8, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Global Styles Issues or PRs that touch theme.json or the base stylesheet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants