Skip to content

Add a review checklist to CONTRIBUTING.md - #500

Merged
kittenkamala merged 2 commits into
WordPress:mainfrom
abdur-emon:docs/44-review-checklist
Oct 14, 2026
Merged

kittenkamala merged 2 commits into
WordPress:mainfrom
abdur-emon:docs/44-review-checklist

Conversation

@abdur-emon

Copy link
Copy Markdown
Contributor

Fixes #44

Description

#44 asks for guidelines on what to check when changes are made, especially changes about Core or Security, and checking those with the relevant teams. CONTRIBUTING.md already says every edit needs two reviews, but it doesn't say what reviewers should check.

This adds a short Review Checklist section to CONTRIBUTING.md, following the proposal in the issue thread, instead of a separate guidelines page.

Changes

CONTRIBUTING.md: new "Review Checklist" section between "Assets in Pages" and "Generating Manifest". Before approving or merging, check that:

  • Facts link to a source: versions, dates and requirements link to a primary source.
  • Core changes match the Core team's documentation: the PHP Compatibility reference and the Requirements page. If unsure, ask in #core.
  • Security guidance has been reviewed by someone with security experience: ask for a reviewer in #hosting. Unfixed vulnerabilities are never described in issues or PRs; they are reported as described in .github/SECURITY.md.
  • The manifest is up to date for new, renamed or moved pages.
  • AI use is disclosed, per the Hosting Team AI Policy (Official AI policy page #431).
  • The PR links its issue with Fixes #123.

Notes

AI Assisted: AI was used to help review the repository and draft this change.

Lists what to check before approving or merging a Pull Request:
sources for facts, Core changes matching the Core team's documentation,
security guidance reviewed by someone with security experience, the
manifest, AI disclosure and linking the issue.

Fixes WordPress#44

@ekamran ekamran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the links, the Security Policy path and the AI Policy wording, and test-merged this with #476 and #477 on current main with no conflicts.

@github-project-automation github-project-automation Bot moved this from Todo to Approved in WordPress Hosting Team Oct 13, 2026
@kittenkamala
kittenkamala merged commit 3ebce77 into WordPress:main Oct 14, 2026
@github-project-automation github-project-automation Bot moved this from Approved to Done in WordPress Hosting Team Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Commit guidelines

4 participants