attempt inline img responsive styles re: performance.md #354 #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqbal-web
approved these changes
Oct 30, 2025
Contributor
|
Testing this pr, it looks good LGTM |
Member
|
I tested this using the browser dev tools, and the responsiveness has improved significantly. Everything works great — this PR is perfect, and so this PR is ready to be merged. Performance.Make.WordPress.Hosting.-.Google.Chrome.2025-10-30.08-39-08.mp4 |
theaminuli
approved these changes
Oct 30, 2025
|
@kittenkamala LGTM! |
Contributor
Author
|
Awesome! Thank you both so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #354
The previous change worked when tested in-browser dev tools but did not translate to the live handbook. There isn't actually a good way to test handbook styles as it stands now, because once live the handbook inherits and is framed by P2 styles. Whereas the isolated codebase does not inherit anything, and browser tools don't interact with the code in the same way.
So I went into make /hosting/wp-admin and edited the page > block > html directly, then used the preview feature to test how that will look and behave when placed in the P2 frame (and scaled up/down). Of course I did not save those changes because then we would have a syncing issue with GitHub.
So anyway, what I landed on is this:
style="max-width: 100%; max-height: 100%; object-fit: contain;"