This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Content attribute type array instead of string in blocks-non-jsx/03-editable block example#228
Merged
ryanwelcher merged 1 commit intoWordPress:trunkfrom Mar 7, 2023
Conversation
ryanwelcher
approved these changes
Mar 7, 2023
Contributor
ryanwelcher
left a comment
ryanwelcher
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed all the attributes in the PHP's block registration, since we have all of them in blocks.json already and they seem to be more correct (blocks.json is using a string instead of an array for content attribute type)
Related bug: #220