Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

01-basic assets loading fix + WPCS#213

Closed
tloureiro wants to merge 2 commits intoWordPress:trunkfrom
tloureiro:basic-block-dependency-fix
Closed

01-basic assets loading fix + WPCS#213
tloureiro wants to merge 2 commits intoWordPress:trunkfrom
tloureiro:basic-block-dependency-fix

Conversation

@tloureiro
Copy link
Copy Markdown
Contributor

@tloureiro tloureiro commented Apr 22, 2022

The plugin is currently not working as is - it seems to be missing the wp-editor dependency. This PR should fix it

@ryanwelcher
Copy link
Copy Markdown
Contributor

Thank you for taking the time to put this together!

We've made some pretty large structural changes to the repo one of which being that we no longer version the generated *.asset.php files.

Just to confirm, did you find this issue in the downloaded plugin on the release or the source code of this repo?

@tloureiro
Copy link
Copy Markdown
Contributor Author

Thank you for taking the time to put this together!

We've made some pretty large structural changes to the repo one of which being that we no longer version the generated *.asset.php files.

Just to confirm, did you find this issue in the downloaded plugin on the release or the source code of this repo?

@ryanwelcher it was in the source code of the plugin

@ryanwelcher
Copy link
Copy Markdown
Contributor

@ryanwelcher it was in the source code of the plugin

Thanks for clarifying. In that case, and based on the changes recently made to no longer version the build files, I'll close this out. Thank you for opening this PR and please feel free to do so for anything you run into moving forward!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants