Repository navigation
Components: Adding a generic token field component - #924
Conversation
youknowriad
added
the
General Interface
|
I do not think we should merge this without automated tests. Fortunately they already exist and we now have a PR to add component tests in this repository (#926). Can we / should we remove some of the unneeded functionality here like a token's |
Sure we can, I don't know if we should? Couldn't this be useful somewhere else? |
c51f7fb to
f33b026
Compare
|
Tests are failing on CI but passing locally but the error is weird. |
f33b026 to
aaa7398
Compare
|
Tests are passing again. I'll appreciate some 👀 here. Thanks |
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
When opening Post Settings on this branch, the page goes blank. I don't see the same on master.
There was a problem hiding this comment.
Odd spacing. Previous variables make no effort in aligning by space.
|
Oh maybe that's related to #957. Could do for a rebase then. |
71ff59c to
586aac8
Compare
|
@aduth Yep, it was related, should be fixed now. |
|
I forgot how slow these tests were, but we're now seeing Travis timeouts in unrelated branches because they take too long. We can bump timeouts, but I'd almost rather remove the tests before allowing ourselves to succumb to accepting slow tests. |
|
Even though these tests use |
In order to do #854 we need a generic Tags Input (with auto-complete...). Building such a component from scratch is not an easy task. So I shamelessly copied the component from Calypso and I adapted it to match our guidelines. It's a lot of code, so I'd appreciate help reviewing this component.
In order to test it. I'm using it in the sidebar with static values.
In a follow-up PR. I'll try to use it to update the post tags.