Skip to content

Icons: Restore the offline icon - #85507

Open
t-hamano wants to merge 1 commit into
trunkfrom
update/restore-offline-icon
Open

Icons: Restore the offline icon#85507
t-hamano wants to merge 1 commit into
trunkfrom
update/restore-offline-icon

Conversation

@t-hamano

@t-hamano t-hamano commented Oct 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What?

Follow-up to #85445

Restores the offline icon that was removed in #85445.

Why?

The offline icon is not used in Gutenberg, but the Contributor Toolkit uses it as the empty state icon shown when the development server or build watch is stopped (site-details.jsx). There doesn't seem to be another icon that represents this state well.

toolkit

How?

Testing Instructions

  1. Run npm run storybook:dev.
  2. Open the Icons library story and confirm the offline icon is listed again.

Use of AI Tools

This PR was authored with Claude Code and reviewed by me.

@claude @t-hamano
Icons: Restore the offline icon
f621662 
Follow-up to #85445. The offline icon is not used in Gutenberg, but the
Contributor Toolkit uses it for the empty state shown when its development
server or build watch is stopped, and no other icon represents that state.

Co-authored-by: t-hamano <54422211+t-hamano@users.noreply.github.com>
@github-actions github-actions Bot added the [Package] Icons /packages/icons label Oct 24, 2026
@github-actions

github-actions Bot commented Oct 24, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 PR meta 🤖

Preview in WordPress Playground

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 761c0b5 trunk % Change
timeToFirstByte 53.55 ms +10.55% -3.83% 52.4 ms +7.92% -3.05% 2.19%
largestContentfulPaint 88 ms +9.09% -4.55% 88 ms +4.55% -4.55% 0%
lcpMinusTtfb 34 ms +16.91% -2.65% 33.4 ms +3.74% -1.95% 1.8%
wpBeforeTemplate 27.67 ms +15% -1.37% 27.56 ms +7.11% -1.38% 0.4%
wpTemplate 20.96 ms +5.92% -3.77% 20.76 ms +6.79% -4.53% 0.96%
wpTotal 49.39 ms +10.85% -3.81% 48.55 ms +8.34% -3.48% 1.73%
wpMemoryUsage 7.68 MB +0% -0% 7.65 MB +0% -0% 0.43%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric 761c0b5 trunk % Change
timeToFirstByte 44.1 ms +7.94% -2.49% 43.3 ms +4.27% -1.39% 1.85%
largestContentfulPaint 100 ms +2% -4% 96 ms +4.17% -0% 4.17%
lcpMinusTtfb 55.25 ms +1.18% -3.8% 53.3 ms +2.81% -0.47% 3.66%
wpBeforeTemplate 24.31 ms +6.91% -1.36% 24.07 ms +2.29% -0.62% 1%
wpTemplate 16.09 ms +2.8% -2.36% 15.93 ms +2.51% -1.76% 1%
wpTotal 40.57 ms +7.89% -1.92% 40.1 ms +4.86% -1.3% 1.17%
wpMemoryUsage 6.37 MB +0% -0% 6.34 MB +0% -0% 0.54%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric 761c0b5 trunk % Change
mediaProcessingJpeg 416.64 ms +3.55% -1.21% 418.68 ms +0.69% -0.18% -0.49%
mediaProcessingAvif 6221.21 ms +0.17% -0.23% 6151.56 ms +0.8% -0.16% 1.13%
mediaProcessingJpegToAvif 4329.63 ms +0.14% -0.04% 4319.46 ms +0.26% -0.04% 0.24%

media-upload

Metric 761c0b5 trunk % Change
jpegUploadProcessing 1458.22 ms +36.15% -2.56% 1428.16 ms +1.22% -0.4% 2.1%
pngUploadProcessing 214.81 ms +6.99% -4.67% 213.65 ms +5.71% -18.02% 0.54%
largeJpegUploadProcessing 1425.58 ms +0.82% -0.3% 1433.95 ms +0.99% -1.14% -0.58%
multipleImageUploadProcessing 1600.83 ms +30.31% -1.51% 1589.21 ms +0.65% -2.32% 0.73%

post-editor

Metric 761c0b5 trunk % Change
serverResponse 341.03 ms +3.94% -13.25% 323.93 ms +5.88% -7.33% 5.28%
firstPaint 393.14 ms +2.32% -32.07% 411.79 ms +4.3% -4.23% -4.53%
domContentLoaded 967.4 ms +1.57% -5.02% 926.79 ms +2.19% -0.33% 4.38%
loaded 968.48 ms +1.57% -5.04% 927.96 ms +2.14% -0.34% 4.37%
firstContentfulPaint 395.72 ms +8.37% -0.77% 416.05 ms +3.23% -2.52% -4.89%
firstBlock 2697.14 ms +1.98% -4.97% 2599.45 ms +1.67% -1.1% 3.76%
type 14.93 ms +2.28% -1.81% 15.66 ms +4.73% -2.23% -4.66%
typeWithoutInspector 15.16 ms +8.71% -6.33% 15.85 ms +2.46% -2.59% -4.35%
typeWithTopToolbar 19.49 ms +2.77% -6.21% 19.42 ms +4.48% -3.96% 0.36%
typeContainer 6.64 ms +4.82% -3.92% 6.84 ms +3.51% -3.22% -2.92%
focus 90.83 ms +3.14% -5.96% 91.84 ms +6.33% -5.8% -1.1%
firstFocus 175.48 ms +0% -0% 169.43 ms +0% -0% 3.57%
selectAll 431.95 ms +4.07% -1.36% 424.72 ms +5.1% -0.1% 1.7%
listViewOpen 64.05 ms +4.17% -6.17% 59.92 ms +3.49% -7.29% 6.89%
inserterOpen 34.24 ms +5.46% -2.34% 34.97 ms +3.43% -13.58% -2.09%
inserterHover 10.11 ms +9.2% -7.02% 9.8 ms +12.96% -4.29% 3.16%
inserterSearch 7.77 ms +8.75% -9.01% 7.01 ms +7.99% -2.28% 10.84%
loadPatterns 524.23 ms +2.84% -3.04% 518.85 ms +3.9% -3.56% 1.04%
wpTotal 332.17 ms +3.75% -13.42% 315.4 ms +5.68% -7.49% 5.32%
wpMemoryUsage 14.71 MB +0% -0% 14.68 MB +0% -0% 0.24%
wpDbQueries 54.5 +0.92% -0.92% 55 +0% -1.82% -0.91%

site-editor

Metric 761c0b5 trunk % Change
serverResponse 486.52 ms +4.9% -2.82% 487.33 ms +2.74% -2.39% -0.17%
firstPaint 222.17 ms +13.09% -6.85% 244.23 ms +9.33% -6.88% -9.03%
domContentLoaded 1278.21 ms +0.6% -1.01% 1252.95 ms +1.06% -2.15% 2.02%
loaded 1279.33 ms +0.6% -1.01% 1254.06 ms +1.06% -2.17% 2.02%
firstContentfulPaint 495.93 ms +4.67% -8.77% 484.69 ms +2.92% -20.39% 2.32%
firstBlock 4561.44 ms +0.79% -0.53% 4536.9 ms +0.42% -0.41% 0.54%
type 17.93 ms +4.63% -3.35% 17.77 ms +4.5% -1.46% 0.9%
navigate 107.37 ms +10.59% -2.61% 107.31 ms +7.56% -2.58% 0.06%
loadPatterns 1249.17 ms +7.29% -7.3% 1236.25 ms +3.88% -3.07% 1.05%
loadPages 983.87 ms +3.37% -2.87% 946.21 ms +3.94% -1.16% 3.98%
wpTotal 477.69 ms +4.84% -2.86% 478.19 ms +2.85% -2.44% -0.1%
wpMemoryUsage 12.73 MB +0% -0% 12.70 MB +0% -0% 0.24%
wpDbQueries 44 +2.27% -0% 44 +2.27% -0% 0%

f621662 Run

@t-hamano t-hamano added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 24, 2026
@t-hamano t-hamano self-assigned this Oct 24, 2026
@t-hamano
t-hamano requested review from fushar and jasmussen October 24, 2026 13:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasmussen jasmussen Awaiting requested review from jasmussen
@fushar fushar Awaiting requested review from fushar

At least 1 approving review is required to merge this pull request.

Assignees

@t-hamano t-hamano

Labels

[Package] Icons /packages/icons [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-hamano @claude