Skip to content

Repair wp/7.1 branch Actions: Point the bullseye security apt sources at archive.debian.org - #85485

Open
desrosj wants to merge 1 commit into
fix-actions-7.1/pin-runner-imagesfrom
fix-actions-7.1/archive-bullseye-security-apt-source
Open

desrosj wants to merge 1 commit into
fix-actions-7.1/pin-runner-imagesfrom
fix-actions-7.1/archive-bullseye-security-apt-source

Conversation

@desrosj

@desrosj desrosj commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Part of #82781.

What?

Backports #85469 to this branch's wp-env: the bullseye-security apt sources of the bullseye-based WordPress images (PHP 7.3, 7.4, and 8.0) now point at archive.debian.org instead of being deleted.

Why?

When #82478 was written, bullseye-security was not on archive.debian.org yet, so it was dropped rather than rewritten. That change is already on this branch. The archive has served the suite since 2026-09-12 (http://archive.debian.org/debian-security/dists/bullseye-security/Release). While the suite is dropped, images built by wp-env install packages without Debian's security updates. For example, libc6 resolves to 2.31-13+deb11u11 from bullseye instead of 2.31-13+deb11u14 from bullseye-security.

This was raised in review of the wp/6.9 backport of #82478 (#82873 (comment)). The same fix was added to the wp/7.0 through wp/6.3 stacks in the pull requests that already handle the bullseye apt sources. wp/7.1 has no such pull request, because #82478 was already on the branch (3b49e92). #85469 will not be backported to wp/7.1 now that wp/7.2 exists, so this pull request adds the fix to the stack, in the same position as the bullseye pull requests on the other branches: above pin-runner-images (#82792) and below pin-wp-env-core-version (#82791).

How?

Same change as #85469 in packages/env/lib/runtime/docker/docker-config.js:

  • Replaces the /bullseye-security/d deletion with two rewrites, matching how the stretch and buster security suites are already handled. Both are needed because the images do not agree on the host: wordpress:php7.3 uses security.debian.org/debian-security, and wordpress:php7.4 and wordpress:php8.0 use deb.debian.org/debian-security.
  • Removes the outdated comment saying the security suite is not on the archive yet. bullseye-updates is still dropped, as buster-updates and stretch-updates are.
  • Adds the changelog entry from wp-env: Keep Debian security updates in Bullseye-based images #85469.

Testing Instructions

  1. In a directory with a .wp-env.json that sets "phpVersion": "7.3", run node /path/to/gutenberg/packages/env/bin/wp-env start using this branch's checkout. Repeat with "7.4" and "8.0".
  2. Confirm each image builds without apt-get errors.
  3. Run node /path/to/gutenberg/packages/env/bin/wp-env run cli cat /etc/apt/sources.list and confirm the bullseye-security line points at archive.debian.org/debian-security.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added [Type] Build Tooling Issues or PRs related to build tooling [Tool] Env /packages/env labels Oct 23, 2026
@desrosj desrosj self-assigned this Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8d051c90-ed1b-4859-8758-9db9e72a0bf5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 7.75 MB

675661a Run

@desrosj
desrosj changed the base branch from fix-actions-7.1/pin-e2e-php-version to wp/7.1 October 24, 2026 18:01
@desrosj
desrosj force-pushed the fix-actions-7.1/archive-bullseye-security-apt-source branch from 7a6f433 to 675661a Compare October 24, 2026 18:02
@desrosj
desrosj changed the base branch from wp/7.1 to fix-actions-7.1/pin-runner-images October 24, 2026 18:02
@desrosj
desrosj marked this pull request as ready for review October 24, 2026 18:03
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@desrosj
desrosj added this pull request to stack #85508 October 24, 2026 18:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Tool] Env /packages/env [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant