Skip to content

Repair wp/6.5 branch Actions: Fix flaky Composite and Tabs unit tests - #85478

Open
desrosj wants to merge 1 commit into
fix-actions-6.5/pin-e2e-php-versionfrom
fix-actions-6.5/fix-flaky-composite-unit-tests
Open

Repair wp/6.5 branch Actions: Fix flaky Composite and Tabs unit tests#85478
desrosj wants to merge 1 commit into
fix-actions-6.5/pin-e2e-php-versionfrom
fix-actions-6.5/fix-flaky-composite-unit-tests

Conversation

@desrosj

@desrosj desrosj commented Oct 23, 2026

Copy link
Copy Markdown
Member

Part of #82928.

What?

Backports #58968 (61aa8f5), "Components: Try fixing some flaky Composite and Tabs tests", to wp/6.5. It waits for rendering to finish (await sleep()) before pressing Tab, and waits for focus to move (waitFor) before checking it, in two tests:

  • With "spread" state › Supports currentId in the legacy Composite tests.
  • Tabs › Controlled mode › When selectOnMove is false › should apply focus without automatically changing the selected tab.

Why?

The Composite test is flaky on this branch. It failed the Unit Tests / JavaScript job on #84588 (https://github.com/WordPress/gutenberg/actions/runs/39291570105/job/118193254896): after pressing Tab, focus stayed on Item 1 instead of moving to Item 2. That PR only changes the Tabs tests, and the same job passed on its previous run.

This is the same timing problem #84588 fixes in a different Tabs test. Trunk fixed both tests in #58968, merged on 2024-02-14, just after wp/6.5 branched. wp/6.6 already has this fix, and wp/6.7 and later fixed the underlying cause by upgrading @ariakit/test, so no other branch needs it.

How?

A straight cherry-pick of the trunk commit. It changes only packages/components/src/composite/legacy/test/index.tsx and packages/components/src/tabs/test/index.tsx.

Testing Instructions

Check that the Unit Tests / JavaScript job on this pull request passes.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added [Type] Build Tooling Issues or PRs related to build tooling [Package] Components /packages/components labels Oct 23, 2026
@desrosj desrosj self-assigned this Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5cb7a5f6-d82b-4627-beac-820e7abb7e17

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj added this pull request to stack #85338 October 23, 2026 15:11
@github-actions

github-actions Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This was referenced Oct 23, 2026
Open
Open
ntsekouras
ntsekouras approved these changes Oct 23, 2026
View reviewed changes

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@desrosj
desrosj force-pushed the fix-actions-6.5/fix-flaky-composite-unit-tests branch from 7a3eb9c to 2f68e34 Compare October 23, 2026 17:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

Assignees

@desrosj desrosj

Labels

[Package] Components /packages/components [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ntsekouras