Repository navigation
Code editor: Show design system focus ring on the title and content fields - #85468
Draft
R1shabh-Gupta wants to merge 2 commits into
Draft
R1shabh-Gupta wants to merge 2 commits into
R1shabh-Gupta wants to merge 2 commits into
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #80138
In the Code editor, the title and content fields now show the same design system focus ring. The title no longer shows a doubled ring.
Why?
TextareaControl, which already draws the design system ring. The Code editor styles added a box-shadow ring and a theme-colored border on top of it, so it showed two rings.How?
TextareaControl's own ring shows.outset-ring__focus()and resets the border color and box-shadow that wp-admin'sforms.cssapplies on focus, matching how the design system's own text fields work.position: relative, which no longer have any effect.PostTitleRaw's top margin from2pxtocalc(2 * var(--wpds-border-width-focus)), so the ring isn't hidden under the sticky "Exit code editor" toolbar.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools
This PR was developed with the assistance of Claude Code.