Repository navigation
CreateTemplatePartModal: Use design system focus ring - #85447
Open
yashjawale wants to merge 2 commits into
Open
yashjawale wants to merge 2 commits into
yashjawale wants to merge 2 commits into
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
yashjawale
marked this pull request as ready for review
October 23, 2026 08:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #80138
Updates the area selection in create template part modal to use design system's focus ring.
Why?
In the new design system, the button's focus ring is represented by an outline. Additionally, the focus ring for the components/Button component is now represented by an outline instead of a box-shadow.
There are still many legacy box-shadow-based focus styles present throughout the Gutenberg codebase. This PR changes the styling of CreateTemplatePartModal towards the same direction.
How?
Replace box-shadow based rules for radio button to use the
@include outset-ring__focus()mixin instead.Pull the ring inwards by setting outline-offset to 0 to match the previous appearance.
Testing Instructions
/wp-admin/site-editor.php?p=%2FpatternScreenshots or screencast
Use of AI Tools
None