Repository navigation
[WP 7.2] DataViews: Use the design system focus ring for list items - #85435
Merged
t-hamano merged 1 commit intoOct 23, 2026
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the |
…s#85358) * DataViews: Use the design system focus ring for list items. * DataViews: Add Changelog Entry --- Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
SainathPoojary
force-pushed
the
backport/85358-dataviews-list-focus-ring-wp-7.2
branch
from
October 23, 2026 06:19
323d74c to
48f8029
Compare
SainathPoojary
marked this pull request as ready for review
October 23, 2026 07:07
SainathPoojary
requested review from
gigitux,
ntsekouras and
oandregal
as code owners
October 23, 2026 07:07
t-hamano
approved these changes
Oct 23, 2026
t-hamano
added
the
props-bot
github-actions
Bot
removed
the
props-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #85358 to
wp/7.2, following the failed automatic cherry-pick.What?
Use the design system outline for keyboard focus on DataViews list items.
Why?
List items still use a legacy box-shadow focus ring with a separate high contrast fallback.
How?
Replace the shadow and transparent outline with
outset-ring__focus(). Use a negative outline offset to keep the ring inside the item.In high contrast mode, the inset focus ring is now separate from the row separators. Resolved the changelog merge conflict in
packages/dataviews/CHANGELOG.mdunderUnreleased.Testing Instructions
Screenshots or screencast
See before/after screenshots in #85358.
Verification
npm run lint:css packages/dataviews/src/components/dataviews-layouts/list/style.scss): Passed with 0 violations.npm run lint:changelogs): Passed.