Skip to content

[WP 7.2] Global Styles: Add icons and tweak styling for element and block buttons - #85414

Merged
andrewserong merged 1 commit into
wp/7.2from
backport/85363-element-icons-wp-7.2
Oct 23, 2026
Merged

[WP 7.2] Global Styles: Add icons and tweak styling for element and block buttons#85414
andrewserong merged 1 commit into
wp/7.2from
backport/85363-element-icons-wp-7.2

Conversation

@andrewserong

@andrewserong andrewserong commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

What?

Backports #85363 (adding icons for the elements buttons in global styles) to WP 7.2.

Why?

The manual backport is required due to merge conflicts an on import line, since trunk's linting is slightly different to this branch.

How?

Cherry pick steps in: #85363 (comment)

Testing Instructions

Smoke test that the elements buttons in Global styles (styling for elements + buttons) have icons and that everything lines up correctly.

Use of AI Tools

Claude Code (Opus 5.5) to help with the merge conflicts

@andrewserong @ramonjd
@mikachan @jasmussen
Global Styles: Add icons and tweak styling for element and block butt…
540accb 
…ons (#85363)

* Global Styles: Add icons and tweak styling for element and blocks buttons in global styles

* Update changelog

* Make sure the comment is in the right place

Unlinked contributors: jinaparekh14.

Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
@andrewserong andrewserong self-assigned this Oct 22, 2026
@andrewserong andrewserong added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 PR meta 🤖

Preview in WordPress Playground

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

📦 Bundle size

Size Change: +2.15 kB (+0.02%)

Total Size: 9.04 MB

📦 View Changed
Filename Size Change
build/scripts/edit-site/index.min.js 421 kB +919 B (+0.22%)
build/scripts/editor/index.min.js 615 kB +1.08 kB (+0.18%)
build/styles/edit-site/style-rtl.css 21.7 kB +28 B (+0.13%)
build/styles/edit-site/style-rtl.min.css 17.5 kB +17 B (+0.1%)
build/styles/edit-site/style.css 21.7 kB +28 B (+0.13%)
build/styles/edit-site/style.min.css 17.5 kB +15 B (+0.09%)
build/styles/editor/style-rtl.css 31.3 kB +11 B (+0.04%)
build/styles/editor/style-rtl.min.css 26.8 kB +21 B (+0.08%)
build/styles/editor/style.css 31.4 kB +13 B (+0.04%)
build/styles/editor/style.min.css 26.7 kB +18 B (+0.07%)

540accb Run

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric d226230 wp/7.2 % Change
timeToFirstByte 53.45 ms +12.82% -1.5% 52.65 ms +8.17% -1.42% 1.52%
largestContentfulPaint 94 ms +10.64% -6.38% 88 ms +6.82% -4.55% 6.82%
lcpMinusTtfb 36 ms +14.31% -3.47% 33.4 ms +7.63% -1.35% 7.78%
wpBeforeTemplate 28.49 ms +19.66% -1.05% 28.22 ms +12.54% -1.38% 0.96%
wpTemplate 20.99 ms +4.1% -2.29% 20.83 ms +6.29% -4.7% 0.77%
wpTotal 49.89 ms +12.03% -1.98% 49.01 ms +8.57% -1.75% 1.8%
wpMemoryUsage 7.66 MB +0% -0% 7.63 MB +0% -0% 0.42%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric d226230 wp/7.2 % Change
timeToFirstByte 45.8 ms +6.44% -0.87% 45.65 ms +5.7% -2.3% 0.33%
largestContentfulPaint 100 ms +4% -0% 100 ms +0% -2% 0%
lcpMinusTtfb 55 ms +1.55% -1.27% 53.4 ms +2.72% -2.06% 3%
wpBeforeTemplate 26.62 ms +7.55% -1.65% 26.65 ms +10.81% -2.55% -0.11%
wpTemplate 15.88 ms +3.78% -1.7% 15.89 ms +4.72% -2.45% -0.06%
wpTotal 42.73 ms +6.69% -1.66% 42.71 ms +5.78% -2.15% 0.05%
wpMemoryUsage 6.35 MB +0% -0% 6.32 MB +0% -0% 0.52%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric d226230 wp/7.2 % Change
mediaProcessingJpeg 400.51 ms +0.53% -1.42% 401.82 ms +0.51% -0.36% -0.33%
mediaProcessingAvif 6053.41 ms +0.08% -0.13% 6062.81 ms +0.2% -0.19% -0.16%
mediaProcessingJpegToAvif 4179.02 ms +0.03% -0.29% 4204.71 ms +0.06% -0.06% -0.61%

media-upload

Metric d226230 wp/7.2 % Change
jpegUploadProcessing 1436.96 ms +36.78% -1.49% 1442.88 ms +0.17% -0.62% -0.41%
pngUploadProcessing 180.24 ms +21.13% -4.39% 210.89 ms +3.48% -14.27% -14.53%
largeJpegUploadProcessing 1425.39 ms +1.75% -0.86% 1425.8 ms +0.43% -1.25% -0.03%
multipleImageUploadProcessing 1594.43 ms +0.5% -0.99% 1596.87 ms +29.42% -2.83% -0.15%

post-editor

Metric d226230 wp/7.2 % Change
serverResponse 250.86 ms +3.23% -8.4% 236.65 ms +7.7% -5.65% 6%
firstPaint 193.94 ms +59.22% -18.21% 232.06 ms +29.7% -25.99% -16.43%
domContentLoaded 687.39 ms +3.74% -4.77% 689.81 ms +4.34% -6.04% -0.35%
loaded 688.12 ms +3.72% -4.77% 690.63 ms +4.34% -6.02% -0.36%
firstContentfulPaint 309.61 ms +3.79% -25.63% 316.47 ms +1.94% -5.09% -2.17%
firstBlock 2104.07 ms +2.6% -1.76% 2120.04 ms +3.37% -4.45% -0.75%
type 13.18 ms +3.19% -4.78% 12.56 ms +8.12% -3.98% 4.94%
typeWithoutInspector 13.17 ms +2.58% -1.75% 12.66 ms +9.87% -1.58% 4.03%
typeWithTopToolbar 16.09 ms +6.22% -5.53% 16.03 ms +1.75% -5.68% 0.37%
typeContainer 6.28 ms +7.01% -2.71% 5.39 ms +10.76% -2.78% 16.51%
focus 73.84 ms +10.83% -2.18% 64.19 ms +6.01% -1% 15.03%
firstFocus 132.98 ms +0% -0% 132.39 ms +0% -0% 0.45%
selectAll 339.14 ms +0.37% -0.17% 320.66 ms +1.41% -1.22% 5.76%
listViewOpen 46.94 ms +3.52% -4.07% 44.62 ms +20.06% -8.11% 5.2%
inserterOpen 26.44 ms +9.08% -3.06% 25.43 ms +6.41% -4.33% 3.97%
inserterHover 7.93 ms +8.7% -9.21% 8.36 ms +7.78% -11.24% -5.14%
inserterSearch 6.22 ms +2.89% -3.7% 6.12 ms +4.41% -1.8% 1.63%
loadPatterns 414.4 ms +2.35% -3.3% 406.43 ms +1.78% -3.8% 1.96%
wpTotal 244.52 ms +2.76% -8.86% 230.2 ms +7.55% -6.1% 6.22%
wpMemoryUsage 14.67 MB +0% -0% 14.66 MB +0% -0% 0.09%
wpDbQueries 55 +0% -0% 55 +0% -0% 0%

site-editor

Metric d226230 wp/7.2 % Change
serverResponse 300.06 ms +1.29% -7.29% 286.54 ms +2.03% -6.6% 4.72%
firstPaint 225.59 ms +11.3% -11.45% 190.55 ms +11.81% -3.71% 18.39%
domContentLoaded 891.79 ms +3.23% -1.75% 831.26 ms +2.71% -0.7% 7.28%
loaded 892.71 ms +3.25% -1.77% 831.92 ms +2.72% -0.7% 7.31%
firstContentfulPaint 362.58 ms +5.89% -22.47% 353.58 ms +3.52% -4.75% 2.55%
firstBlock 3399.62 ms +2.94% -0.57% 3187.16 ms +2.36% -1.87% 6.67%
type 17.67 ms +3.85% -5.15% 16.09 ms +4.72% -5.84% 9.82%
navigate 96.43 ms +6.75% -3.28% 86.23 ms +23.61% -0.68% 11.83%
loadPatterns 992.91 ms +5.48% -7.01% 939.47 ms +6.92% -10.27% 5.69%
loadPages 1068.72 ms +1.72% -1.51% 1006.87 ms +4.18% -2.77% 6.14%
wpTotal 292.69 ms +1.34% -7.46% 279.65 ms +1.81% -6.77% 4.66%
wpMemoryUsage 12.71 MB +0% -0% 12.67 MB +0% -0% 0.27%
wpDbQueries 44 +2.27% -0% 44.5 +1.12% -1.12% -1.12%

540accb Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Regression: updating a specific option will only change its value and will not corrupt others in /test/e2e/specs/editor/various/core-settings.spec.js, passed after 1 failed attempt. 
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
    "rewrite_rules",
-   "SERIALIZED DATA",
+   "",
  ]
    at forEach (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:46:26)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/core-settings.spec.js:43:35
keeps the blocks selected after dropping a multi-selection in /test/e2e/specs/editor/various/draggable-blocks.spec.js, passed after 1 failed attempt. 
TypeError: Cannot read properties of null (reading 'y')
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/draggable-blocks.spec.js:824:57
    at dragSelectionBelowLanding (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/draggable-blocks.spec.js:823:3)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/draggable-blocks.spec.js:908:3
refuses the drop and uploads nothing in /test/e2e/specs/editor/various/single-file-placeholder-drop.spec.js, passed after 1 failed attempt. 
Error: expect(received).toHaveLength(expected)

Expected length: 0
Received length: 1
Received array:  [{"_links": {"about": [{"href": "http://localhost:8889/wp-json/wp/v2/types/attachment"}], "author": [{"embeddable": true, "href": "http://localhost:8889/wp-json/wp/v2/users/1"}], "collection": [{"href": "http://localhost:8889/wp-json/wp/v2/media"}], "curies": [{"href": "https://api.w.org/{rel}", "name": "wp", "templated": true}], "replies": [{"embeddable": true, "href": "http://localhost:8889/wp-json/wp/v2/comments?post=223"}], "self": [{"href": "http://localhost:8889/wp-json/wp/v2/media/223", "targetHints": {"allow": ["GET", "POST", "PUT", "PATCH", "DELETE"]}}], "wp:attached-to": [{"embeddable": true, "href": "http://localhost:8889/wp-json/wp/v2/posts/222", "id": 222, "post_type": "post"}]}, "alt_text": "", "author": 1, "caption": {"rendered": ""}, "class_list": ["post-223", "attachment", "type-attachment", "status-inherit", "hentry", "entry"], "comment_status": "open", "date": "2026-10-22T22:56:51", "date_gmt": "2026-10-22T22:56:51", "description": {"rendered": "<p class=\"attachment\"><a href='http://localhost:8889/wp-content/uploads/2026/10/3873b0e8-515a-452e-903c-a984fe4de37f.png'><img loading=\"lazy\" decoding=\"async\" width=\"10\" height=\"10\" src=\"http://localhost:8889/wp-content/uploads/2026/10/3873b0e8-515a-452e-903c-a984fe4de37f.png\" class=\"attachment-medium size-medium\" alt=\"\" style=\"width:100%;height:100%;max-width:10px;\" /></a></p>
"}, "featured_media": 0, "filename": "3873b0e8-515a-452e-903c-a984fe4de37f.png", "filesize": 80, "guid": {"rendered": "http://localhost:8889/wp-content/uploads/2026/10/3873b0e8-515a-452e-903c-a984fe4de37f.png"}, "id": 223, "link": "http://localhost:8889/?attachment_id=223", "media_details": {"file": "2026/10/3873b0e8-515a-452e-903c-a984fe4de37f.png", "filesize": 80, "height": 10, "image_meta": {"alt": "", "aperture": "0", "camera": "", "caption": "", "copyright": "", "created_timestamp": "0", "credit": "", "focal_length": "0", "iso": "0", "keywords": [], "orientation": "0", "shutter_speed": "0", "title": ""}, "sizes": {}, "width": 10}, "media_type": "image", "meta": [], "mime_type": "image/png", "modified": "2026-10-22T22:56:51", "modified_gmt": "2026-10-22T22:56:51", "ping_status": "closed", "post": 222, "slug": "3873b0e8-515a-452e-903c-a984fe4de37f", "source_url": "http://localhost:8889/wp-content/uploads/2026/10/3873b0e8-515a-452e-903c-a984fe4de37f.png", "status": "inherit", "template": "", "title": {"rendered": "3873b0e8-515a-452e-903c-a984fe4de37f"}, "type": "attachment"}]
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/single-file-placeholder-drop.spec.js:71:45

540accb Run

@andrewserong
andrewserong requested a review from ramonjd October 22, 2026 23:19
ramonjd
ramonjd approved these changes Oct 23, 2026
View reviewed changes

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code matches #85363

Smoke tested the branch too.

Thanks!

Image

@andrewserong

andrewserong commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the confidence check! 🙇

@andrewserong
andrewserong merged commit 706247e into wp/7.2 Oct 23, 2026
94 of 98 checks passed
@andrewserong
andrewserong deleted the backport/85363-element-icons-wp-7.2 branch October 23, 2026 00:05
@andrewserong andrewserong mentioned this pull request Oct 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonjd ramonjd ramonjd approved these changes

Assignees

@andrewserong andrewserong

Labels

Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewserong @ramonjd