Repository navigation
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
tbradsha
marked this pull request as ready for review
October 22, 2026 19:23
Contributor
|
The packages mentioned on the PR are meant to be bundled, it's a choice of the components team. This feels like it goes against that decision, so I'm not really sure we should do this. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #85385 - Add
@wordpress/buildexternals option to load packages from a script moduleWhy?
Before this PR, every package or route built with
@wordpress/buildbundles its own copy of each dependency that isn't a WordPress script, such as@wordpress/uior@wordpress/dataviews. That means that if a plugin consumes multiple packages, it ends up with many copies of the same dependency bundled, which can significantly balloon the size of the final parent build.This PR allows a plugin's bundles to import a package from a script module the plugin registers, instead of bundling their own copy or using the version that comes with Core.
How?
Adds a
wpPlugin.externalsoption that maps a package to a script module ID. The createWordpressExternalsPlugin plugin then rewrites imports of that package to the ID and adds it to module_dependencies instead of bundling it.Testing Instructions
In some directory, create the below files and then run
npm build:beforeandnpm build:after. You'll see a size difference.Standing in the Gutenberg root dir, create
sizes.mjsand run it withnode sizes.mjs. Compare the files it created and confirm it's doing what we want.sizes.mjs:Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools
The proposed changes were reviewed locally by Claude.