Repository navigation
DataViews: Use the design system focus ring for Activity titles - #85382
Open
SainathPoojary wants to merge 2 commits into
Open
SainathPoojary wants to merge 2 commits into
SainathPoojary wants to merge 2 commits into
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
SainathPoojary
marked this pull request as ready for review
October 22, 2026 18:57
SainathPoojary
requested review from
gigitux,
ntsekouras and
oandregal
as code owners
October 22, 2026 18:57
SainathPoojary
force-pushed
the
fix/dataviews-activity-title-focus-ring
branch
from
October 22, 2026 19:06
5fd9108 to
f80b29f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Use the shared focus ring for clickable titles in the Activity layout.
Part of #80138.
Why?
Keep focus styling consistent with the design system.
How?
Replace the manual outline rules with
outset-ring__focus(). Keep the rounded corners.Testing Instructions
onClickItem={ () => {} }to<DataViews>inpackages/dataviews/src/dataviews/stories/layout-activity.tsx.hasClickableItemsis enabled.onClickItemline after testing.Screenshots or screencast
Before:
After:
Use of AI Tools
Implemented with assistance of Github Copilot