Repository navigation
Revisions: Show design system focus ring on the code diff - #85368
Open
R1shabh-Gupta wants to merge 2 commits into
Open
R1shabh-Gupta wants to merge 2 commits into
R1shabh-Gupta wants to merge 2 commits into
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
R1shabh-Gupta
marked this pull request as ready for review
October 22, 2026 05:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #80138
The code diff in the revisions screen (Code editor → Revisions) now uses the design system's outline focus ring instead of a legacy box-shadow.
Why?
The ring was an inset box-shadow with
outline: none, so keyboard users had no focus indicator in high contrast (forced colors) mode.How?
outset-ring__focus().outline-offsetso the ring stays inside the region.Testing Instructions
forced-colors: activeand tick "Emulate a focused page", then repeat step 4. The ring should be visible. On trunk there's no indicator.Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools
This PR was developed with the assistance of Claude Code.