Repository navigation
Repair wp/6.2 branch Actions: Upload each E2E job's debug artifacts under its own name - #85331
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Part of #82931.
What?
Gives each E2E upload of
failures-artifactsinend2end-test.ymlits own name, then merges them back into a singlefailures-artifactsartifact in a newmerge-artifactsjob:e2e-puppeteer(4 shards)failures-artifacts--puppeteer-<part>e2e-playwright(one job)failures-artifacts--playwrightThe upload steps also change from
if: always()toif: ${{ !cancelled() }}, so a cancelled run doesn't try to upload anything.Why?
Before #84217 updated
actions/upload-artifactfromv3.1.2tov7.0.1, every upload with the same name was merged into one artifact. Fromv4on, each upload creates its own artifact, so the bump changed what these steps produce (migration notes).With every shard using the same name, a run where more than one shard has debug files ends up with several separate artifacts, all called
failures-artifacts. They look the same in the run summary, and downloadingfailures-artifactsby name returns only one of them. In a trial onwp/6.4, 7 uploads under the shared name produced 7 artifacts, andgh run download -n failures-artifactsreturned the files from just one shard. Today's runs don't show this, because no shard has files to upload unless tests fail or are retried.How?
Backports the artifact half of trunk's 5697864 (#61338):
failures-artifacts, and their shards share part numbers. So the Puppeteer or Playwright prefix is part of the new names, not just the part number trunk uses.merge-artifactsjob matches the one already on thewp/6.6and newer stacks:actions/upload-artifact/mergeat the same pinnedv7.0.1SHA,continue-on-errorso a run with nothing to merge stays green,delete-merged,retention-days: 14,ubuntu-24.04and a 5 minute timeout.Tested with a throwaway workflow in which every E2E job uploaded a dummy file under these names. No upload failed, and the merge job produced one
failures-artifactsartifact holding every job's file, with the per-job artifacts removed.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code