Skip to content

Repair wp/7.1 branch Actions: Pin the PHP version used by the end-to-end tests - #85318

Open
desrosj wants to merge 1 commit into
fix-actions-7.1/limit-fork-runner-osfrom
fix-actions-7.1/pin-e2e-php-version
Open

Repair wp/7.1 branch Actions: Pin the PHP version used by the end-to-end tests#85318
desrosj wants to merge 1 commit into
fix-actions-7.1/limit-fork-runner-osfrom
fix-actions-7.1/pin-e2e-php-version

Conversation

@desrosj

@desrosj desrosj commented Oct 21, 2026

Copy link
Copy Markdown
Member

Part of #82781.

What?

Pins the PHP version used by the end-to-end tests to 8.5, the highest version WordPress 7.1 supports.

Why?

The end-to-end workflow sets no PHP version and .wp-env.json has no phpVersion, so wp-env builds the WordPress containers from the floating wordpress and wordpress:cli images. Those follow Docker Hub's latest tag, which is PHP 8.3 today, and they move to a new PHP version whenever Docker Hub retags latest, with no change on this branch. The unit tests already pin their PHP version through WP_ENV_PHP_VERSION. wp/5.5 ran into this: on the floating image's PHP 8.3, 10 of its end-to-end tests failed, which led to #85012 and #85013.

With this change, the end-to-end tests run on PHP 8.5, a higher version than today's PHP 8.3.

How?

.github/workflows/end2end-test.yml sets WP_ENV_PHP_VERSION: '8.5' in the workflow-level env:. wp-env already reads this variable and builds its WordPress and WP-CLI images from wordpress:php8.5 and wordpress:cli-php8.5, the same images the 8.5 unit-test legs use.

Testing Instructions

Check that the end-to-end jobs on this pull request pass.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 21, 2026
@desrosj desrosj self-assigned this Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 096299f4-ff75-4a01-a5bb-5b6122cd5d31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj added this pull request to stack #85326 October 21, 2026 18:36
@desrosj desrosj mentioned this pull request Oct 21, 2026
Open
@github-actions

github-actions Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 PR meta 🤖

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

should update the URL from the last navigation if only varies in the URL fragment in /test/e2e/specs/interactivity/router-navigate.spec.ts, passed after 1 failed attempt. 
Error: expect(locator).toHaveText(expected) failed

Locator:  getByTestId('title')
Expected: "Link 1"
Received: "Main"
Timeout:  5000ms

Call log:
  - Expect "toHaveText" with timeout 5000ms
  - waiting for getByTestId('title')
    14 × locator resolved to <h2 data-testid="title">Main</h2>
       - unexpected value "Main"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/router-navigate.spec.ts:163:25

bcbcaf6 Run

@desrosj
desrosj marked this pull request as ready for review October 21, 2026 19:24
@github-actions

github-actions Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

This was referenced Oct 22, 2026
Open
Open
@desrosj
desrosj force-pushed the fix-actions-7.1/pin-e2e-php-version branch from bcbcaf6 to 8346c8b Compare October 24, 2026 18:02
@desrosj
desrosj removed this pull request from stack #85326 October 24, 2026 18:04
@desrosj
desrosj added this pull request to stack #85508 October 24, 2026 18:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonjd ramonjd ramonjd approved these changes

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ramonjd