Repository navigation
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #85319
October 21, 2026 18:30
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
desrosj
force-pushed
the
fix-actions-5.6/pin-e2e-php-version
branch
from
October 21, 2026 19:06
558bfcf to
126246e
Compare
desrosj
marked this pull request as ready for review
October 21, 2026 19:23
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Oct 22, 2026
This was referenced Oct 22, 2026
Open
desrosj
force-pushed
the
fix-actions-5.6/pin-e2e-php-version
branch
from
October 23, 2026 14:12
126246e to
fcae5a4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82937.
What?
Pins the PHP version used by the end-to-end tests to
8.0, the highest version WordPress 5.6 supports. This branch'swp-envcan't choose a PHP version for the WordPress and WP-CLI containers, so this also backports theWP_ENV_PHP_VERSIONenvironment variable added towp/5.5in #85012.Why?
The end-to-end workflow sets no PHP version and
.wp-env.jsonhas nophpVersion, sowp-envbuilds the WordPress containers from the floatingwordpressandwordpress:cliimages. Those follow Docker Hub'slatesttag, which is PHP 8.3 today, and they move to a new PHP version whenever Docker Hub retagslatest, with no change on this branch. The unit tests already run PHPUnit on their matrix PHP version, throughLOCAL_PHP.wp/5.5ran into this: on the floating image's PHP 8.3, 10 of its end-to-end tests failed, which led to #85012 and #85013.With this change, the end-to-end tests run on PHP
8.0, a lower version than today's PHP 8.3.How?
packages/env/lib/build-docker-compose-config.jsbuilds the WordPress and WP-CLI services fromwordpress:php${WP_ENV_PHP_VERSION:-8.0}andwordpress:cli-php${WP_ENV_PHP_VERSION:-8.0}, so Docker Compose fills in the version. This is the Repairwp/5.5branch Actions: Add aWP_ENV_PHP_VERSIONenvironment variable #85012 change with WordPress 5.6's highest PHP version as the default. It comes with a test, a README note and apackages/env/CHANGELOG.mdentry. Thephpunitservice still usesLOCAL_PHP..github/workflows/end2end-test.ymlsetsWP_ENV_PHP_VERSION: '8.0'in the workflow-levelenv:, next toWP_ENV_MARIADB_VERSION, aswp/5.5does (Repairwp/5.5branch Actions: Pin PHP to 7.4 in CI #85013).Testing Instructions
Check that the end-to-end jobs on this pull request pass.
Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code