Repository navigation
BorderControl: Remove double focus outline - #85173
Merged
ciampo merged 7 commits intoOct 20, 2026
Merged
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the |
Contributor
Author
|
Originally, the shadow was also showed on hover, which isn't anymore after the change 
After 
Will it be better to add the outline back for hover too? |
yashjawale
marked this pull request as ready for review
October 20, 2026 08:19
ciampo
approved these changes
Oct 20, 2026
ciampo
left a comment
ciampo
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀
The background color on change should be sufficient, thank you!
16 of 17 tasks
ciampo
reviewed
Oct 20, 2026
| - `Snackbar`: Keep snackbars that have an action on screen for 10 seconds instead of 6 before they are dismissed automatically ([#84842](https://github.com/WordPress/gutenberg/pull/84842)). | ||
| - `Tabs`: Show the tab panel's focus ring with the design system's outline instead of a legacy box-shadow ([#84914](https://github.com/WordPress/gutenberg/pull/84914)). | ||
| - `RangeControl`: Add a `size` prop with `default` and `compact` options ([#69844](https://github.com/WordPress/gutenberg/pull/69844)). | ||
| - `BorderControl`: Remove double outline & use design system's focus ring ([#85173](https://github.com/WordPress/gutenberg/pull/85173)). |
Contributor
There was a problem hiding this comment.
Let's move to the new unreleased section
…der-control-80138
…com/yashjawale/gutenberg into fix/focus-ring-border-control-80138
ciampo
enabled auto-merge (squash)
October 20, 2026 11:57
ciampo
added
Backport to Gutenberg RC
github-actions
Bot
removed
the
Backport to WP 7.2 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 20, 2026
* fix: remove duplicate focus outline * docs; add changelog entry * docs: update changelog to use correct section --------- Co-authored-by: yashjawale <yashjawale@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
github-actions
Bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.2 branch to get it included in the next release: 2fc7075 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #80138
This PR removes the double focus rings on BorderControl by removing the box-shadow focus rules so only the ones provided by Button component stays.
Why?
In the new design system, the button's focus ring is represented by an outline. Additionally, the focus ring for the components/Button component is now represented by an outline instead of a box-shadow.
There are still many legacy box-shadow-based focus styles present throughout the Gutenberg codebase. This PR changes the BorderControl component styling towards the same direction.
How?
Testing Instructions
npm run storybook:dev?path=/story/components-bordercontrol--defaultScreenshots or screencast
Use of AI Tools
None