Repository navigation
Repair wp/5.5 branch Actions: Pin phpunit/phpunit to a PHP 5.6/7.0-compatible release - #85016
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #85017
October 16, 2026 20:10
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
This was referenced Oct 16, 2026
Open
desrosj
marked this pull request as ready for review
October 19, 2026 13:20
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Oct 22, 2026
desrosj
force-pushed
the
fix-actions-5.5/fix-phpunit-dev-dependency-floor
branch
from
October 23, 2026 14:12
8a596fe to
1ca2bd8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82938.
What?
composer.json: addsphpunit/phpunit^5.7(resolves to5.7.27), setsconfig.platform.phpto5.6.20andrequire.phpto>=5.6.20, and ignores advisoriesPKSA-z3gr-8qht-p93v,PKSA-v5yj-8nmz-sk2q,PKSA-ft77-7h5f-p3r6,PKSA-b14r-zh1d-vdrcandPKSA-xz3r-9gp4-4m1z.composer.lock: regenerated withcomposer update phpunit/phpunit --with-all-dependencies. Only PHPUnit's dependency tree changes, and it's now the same aswp/5.9's.The workflow doesn't change: every leg keeps running the PHPUnit bundled in its
wordpressdevelop/phpunitimage.Why?
yoast/phpunit-polyfills, which WordPress 5.5's test library requires (#85015, directly below), requiresphpunit/phpunit. Without a constraint, Composer resolved PHPUnit9.6.38intovendor. The test bootstrap loadsvendor/autoload.php, so thePHP 5.6andPHP 7.0legs would load PHPUnit 9.6's classes, which they can't parse.PHPUnit 5.7 is the newest release that parses on PHP 5.6. It's only there for the Polyfills and the autoloader. Each leg's image ships a PHPUnit that WordPress 5.5's test library accepts, so this branch needs nothing else:
5.6-fpm7.0-fpm7.4-fpmHow?
Same setup as
wp/5.9(#84415) andwp/6.0(#84281).wp/5.8,wp/5.7andwp/5.6lock PHPUnit 7.5 and swap it on thePHP 5.6andPHP 7.0legs instead, because theirPHP 8.0legs need it and no PHPUnit 7 image exists for PHP 8.0. This branch has noPHP 8.0leg.platform.php5.6.20is the matrix's lowest PHP version and therequire.phpfloor. With a higher platform, Composer picks dependencies that need PHP 7.1+.PKSA-z3gr-8qht-p93vcovers everyphpunit/phpunitrelease below8.5.52. The foursymfony/yamladvisories cover every 2.x–4.x release, which PHPUnit 5.7 requires. They usewp/5.9's reasons;PKSA-xz3r-9gp4-4m1z(CVE-2026-109413) was published on 2026-08-30, afterwp/5.9's list was written.composer install --dry-runagainst the new lock installs cleanly for PHP 5.6.20, and thePHP coding standardsjob's install on PHP 7.4 only gets PHP 5.6-compatible packages.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code