Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #85017
October 16, 2026 20:10
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
This was referenced Oct 16, 2026
Closed
desrosj
marked this pull request as ready for review
October 19, 2026 13:20
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Oct 21, 2026
desrosj
force-pushed
the
fix-actions-5.5/match-wp-env-php-to-test-matrix
branch
from
October 23, 2026 14:12
4f8b7c0 to
9f868be
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82938.
What?
Sets
WP_ENV_PHP_VERSION: ${{ matrix.php }}on theunit-php(PHP) job inunit-test.yml, next toLOCAL_PHP, so each matrix leg runs the WordPress and WP-CLI containers on the same PHP version as PHPUnit. The job-level value overrides the workflow-level7.4from #85013 for this job only.Why?
LOCAL_PHPonly selects thephpunitservice's image, where the tests run. Thetests-wordpressandtests-clicontainers, which install the test site duringwp-env start, stayed on7.4on every leg. Using the matrix version for every container keeps all of a leg's tooling on one PHP version.How?
wp-envpasses the job environment through to Docker Compose, which fills inWP_ENV_PHP_VERSION(#85012) for thewordpress:php<version>andwordpress:cli-php<version>images. The matrix values (5.6,7.0,7.4) all have tags on Docker Hub. The5.6and7.0images were last built in December 2018 and January 2019, before thewordpressimage'sgetenv_docker()wp-config.phptemplate, so this PR's CI is what shows whether those legs still start cleanly.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.