Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
LGTM, thanks! Left a non-blocking comment here.
|
|
||
| - name: Show PHPCS results in PR | ||
| if: ${{ always() && steps.phpcs-gutenberg.outcome == 'failure' }} | ||
| run: cs2pr ./.cache/phpcs-report.xml |
There was a problem hiding this comment.
Small thing: the other branches keep the git diff --exit-code step at the end of the phpcs job, was dropping it here intentional?
Part of #82938.
What?
Moves PHP coding standards checks (
phpcs) out ofwp-envinto a newphpcsjob inunit-test.yml. The job runs on the runner at PHP 7.4 and reports violations as annotations withcs2pr. It passes--runtime-set ignore_warnings_on_exit 1, as this branch'scomposer run-script lintdoes. The.cache/.gitkeep,.gitignoreandphpcs.xml.distchanges add the PHPCS scan cache. It also setstimeout-minutes: 20on the newphpcsjob, like the other jobs got in #84991.npm run test-phpno longer runslint-phpfirst. The PHPUnit job gets anInstall Composer dependenciesstep (npm run wp-env run composer 'install --no-interaction') afterInstall WordPress.Why?
Coding standards checks don't depend on the PHP version being tested. Inside
wp-envthey only ran after the environment started, they repeated on every leg of the PHP matrix added in #85002, and violations showed up as container logs instead of annotations on the diff.lint-php'sprelint-phphook was the only thing that installed Composer dependencies for PHPUnit, andphpunit/bootstrap.phprequiresvendor/autoload.php. The new step keeps that install, and runs on the multisite legs too, which never had one.The job uses PHP 7.4 because the PHP_CodeSniffer and WPCS releases this branch depends on emit deprecation notices on PHP 8.4 and newer that abort the scan.
How?
Ports the
phpcsjob from #46510 (9ee17a7).Both Composer installs fail until #85004, directly above, adds
config.allow-plugins. With #85004 applied,phpcspasses.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code