Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wp/5.5 branch Actions: Run PHP coding standards on the runner instead of inside wp-env
#85003
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.5 branch Actions: Add a PHP-version test matrixwp/5.5 branch Actions: Add a PHP version test matrix
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Everything red on this PR passes at the top of this stack (#85016).
Matrix matches the PHP compatibility table for this WordPress version: the lowest and highest supported minor of each PHP major.
Part of #82938.
What?
Runs the PHPUnit job in
unit-test.ymlacross a PHP version matrix:5.6,7.0and7.4, each as a single site and a multisite leg.LOCAL_PHPis set to<version>-fpmfrom the matrix, sowp-env'sphpunitcontainer uses thewordpressdevelop/phpunit:<version>-fpmimage.npm run test-php && npm run test-unit-php-multisitestep is split into a single site step and a multisite step, each running in its own leg.Why?
The job ran PHPUnit once, in the
wordpressdevelop/phpunit:latestimage, so it never tested the PHP versions WordPress 5.5 supports. The matrix tests the lowest and highest supported minor version of each major PHP version WordPress 5.5 supports:5.6for PHP 5, and7.0and7.4for PHP 7. WordPress 5.5 doesn't support PHP 8.How?
This branch's
@wordpress/env(1.6.0) has noWP_ENV_PHP_VERSIONsupport, and itswordpressandwordpress:cliimages aren't versioned. Itsphpunitservice image iswordpressdevelop/phpunit:${LOCAL_PHP-latest}, andwp-env runpasses the job's environment through todocker compose, soLOCAL_PHPselects the PHP version PHPUnit runs on. The WordPress containers still run on the floatingwordpressimages' PHP version.test-phprunslint-phpbefore the tests, so linting runs once per PHP version, on the single site leg. #85003 moves PHP coding standards checks into their own job.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.