Repository navigation
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Part of #82938.
What?
Bumps this branch's pinned Node.js version in
.nvmrcfrom12to14, plus the two dependencies that need it:packages/env'snodegit(^0.26.2→^0.27.0) and rootnode-sass(4.13.1→4.14.1).package-lock.jsonis updated to match, including removing thenodegit-promise,promisify-node,request-promise-coreandrequest-promise-nativeentries that onlynodegit@0.26needed.Because the PR below this one made
.nvmrcthe single source of truth for everyactions/setup-nodestep, the one-line.nvmrcchange is all that is needed to move CI to Node 14 — no workflow file is touched here.Why?
wp/5.5andwp/5.6are the only branches in this project'swp/5.1–wp/7.1range still pinned to Node 12. Every sibling branch fromwp/5.7onward received a direct follow-up commit shortly after its own WordPress release moving to14(fixing either the same stale literal, or a floatinglts/*reference left to drift on an already-frozen branch), a fixwp/5.5never received.Staying on Node 12 also blocks the Docker Compose v2 migration (#84999, directly above): every
docker-composenpm release after0.24.0depends onyaml@2.x, which requires Node 14 and uses optional chaining (?.) that Node 12 can't parse. With this PR below it, #84999 uses trunk's^0.24.3range (0.24.8) instead of pinning0.24.0.Two
devDependenciesneeded a version bump to get Node-14-compatible prebuilt binaries, verified against the real npm registry:packages/env'snodegit(used only bypackages/env/lib/download-source.js, which clones WordPress core into the localwp-envtest environment;@wordpress/envis a development tool that WordPress 5.5 doesn't bundle) has no prebuilt binary for Node 14's ABI at0.26.2, and itsnode-gypsource-build fallback fails under a modern Python 3.^0.27.0ships a Node-14 binary.node-sass(used bybin/packages/build-worker.jsandpackages/react-native-editor/sass-transformer.js) has the same gap at4.13.1.4.14.1ships a Node-14 binary; the only functional difference between the two releases isnode-sass's ownsass-graphdependency bump, not anything that touches Sass compilation output.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.