Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wp/5.5 branch Actions: Run PHP coding standards on the runner instead of inside wp-env
#85003
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adimoldovan
left a comment
adimoldovan
left a comment
There was a problem hiding this comment.
Looks good. CI failures are not relevant to the changes of this PR.
Part of #82938.
What?
Adds
timeout-minutesto the CI jobs on this branch that don't have one:bundle-size.ymlbuildCheckcreate-block.ymlbuildend2end-test.ymladmin-1end2end-test.ymladmin-2end2end-test.ymladmin-3end2end-test.ymladmin-4static-checks.ymlcheckAllunit-test.ymlunit-phpOne more job gets a timeout further up the stack, in the PR that adds it:
unit-test.ymlphpcs(PHP coding standards): 20, added in Repairwp/5.5branch Actions: Run PHP coding standards on the runner instead of inside wp-env #85003, the PR that creates the job.Why?
Without
timeout-minutes, a stuck job runs until GitHub's 360-minute default. On 2026-10-07, Playwright shards onwp/7.1–wp/6.2hung for 2.3–3 hours inplaywright install --with-depswhile an Ubuntu apt mirror was degraded. Trunk added job timeouts for this in 27f57c9 (#80801).This branch doesn't run
--with-deps, so here the timeouts guard against hangs in general.How?
Uses trunk's values from #80801 and 9ee17a7 (#46510) where this branch's job durations fit under them, and raises them where they don't, because on these branches every job builds and installs on its own without trunk's shared build and apt cache:
Check: Runs on otherwp/X.Ybranches have taken 14.2 minutes, so trunk's 15 is too tight.wp/X.Ybranches have taken 11.1 minutes, so trunk's 10 would cut them off.Each
timeout-minutesgoes next to the job'sruns-on. There is no step-level timeout on dependency installs: successful installs have taken up to 21 minutes.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code