Repository navigation
Repair wp/5.6 branch Actions: Handle a missing widget name when saving a widget in the widgets REST controller - #84978
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84979
October 16, 2026 17:49
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 16, 2026 18:07
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-5.6/fix-widgets-controller-missing-name
branch
from
October 19, 2026 17:09
505ebcf to
44c099e
Compare
desrosj
removed this pull request from stack #84979
October 21, 2026 18:30
desrosj
added this pull request to stack #85319
October 21, 2026 18:30
ntsekouras
approved these changes
Oct 22, 2026
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! The three widget tests no longer fail on PHP 8.0, and all PHP jobs pass here.
desrosj
force-pushed
the
fix-actions-5.6/fix-widgets-controller-missing-name
branch
from
October 23, 2026 14:12
44c099e to
7457886
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82937.
What?
In
WP_REST_Widgets_Controller::save_widget(), passesnullas the widget name when the request has noname, instead of reading$input_widget['name']unconditionally.Why?
The request doesn't have to include
name. On PHP 8 the missing key is a warning, so threeREST_Widgets_Controller_Testtests (test_create_item,test_create_item_multiple_in_a_rowandtest_update_item_shouldnt_require_id_base) fail on thePHP 8.0jobs of #84977, directly below:These endpoints first shipped in WordPress 5.8. On this branch they exist only as plugin code in
lib/, which isn't in any npm package and never reaches a WordPress 5.6 release. A small change here keeps the tests green, so security fixes for the packages WordPress 5.6 does ship can be verified reliably.How?
The
isset()ternary passes the samenullPHP 7 already passed, so behavior is unchanged. It's used instead of??because this file also loads on PHP 5.6. Later versions of this controller were rewritten, so there's no upstream fix to port. This is the same change as #84794 onwp/5.7: this branch'slib/class-wp-rest-widgets-controller.phpis identical towp/5.7's before that PR.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code