Repository navigation
Repair wp/5.6 branch Actions: Swap phpunit/phpunit for a release PHP 5.6 and 7.0 can load - #84976
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84979
October 16, 2026 17:49
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 16, 2026 18:07
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-5.6/remove-phpunit-for-old-php
branch
from
October 19, 2026 17:09
7c73caa to
917995b
Compare
desrosj
removed this pull request from stack #84979
October 21, 2026 18:30
desrosj
added this pull request to stack #85319
October 21, 2026 18:30
desrosj
force-pushed
the
fix-actions-5.6/remove-phpunit-for-old-php
branch
from
October 23, 2026 14:12
917995b to
94582f6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82937.
What?
Adds an "Install a PHPUnit release this PHP version can load" step to the
unit-phpjob ofunit-test.yml. On thePHP 5.6andPHP 7.0legs, after the Composer dependencies are installed, it setsconfig.platform.phpto5.6.20or7.0.33and runscomposer require --dev phpunit/phpunit:<version> --with-all-dependenciesinwp-env'scomposercontainer:^5.7.21on PHP 5.6 (resolves to5.7.27) and^6.5on PHP 7.0 (6.5.14). The tests still run the PHPUnit bundled in those legs'wordpressdevelop/phpunitimages.Why?
wp-env'scomposerservice installs the dev dependencies with its own PHP version, sovendorcontainsphpunit/phpunit7.5.20(#84975) on every leg. The test bootstrap loadsvendor/autoload.php, which autoloads PHPUnit 7.5's classes, and PHP 5.6 and 7.0 can't parse them:Removing
phpunit/phpunitisn't possible:yoast/phpunit-polyfills, which WordPress 5.6's test library requires (#84974), requires it.composer removefails ("Removal failed, phpunit/phpunit is still present"), and re-resolves PHPUnit to9.6.38on the way, which is a fatal error on PHP 5.6. So these legs swap it for the newest release their PHP supports instead. These are the same PHPUnit lines their images ship.The changes to
composer.jsonandcomposer.lockonly exist inside the job.How?
wp/5.8andwp/5.7make the same change (#84456, #84774). The condition is the same one thePHPUNITvariable uses to pick the image's PHPUnit.wp/6.0andwp/5.9lock PHPUnit 5.7 for every leg instead, because their test libraries accept the PHPUnit 8.5 and 9.6 that the newer images ship. Here thePHP 7.4andPHP 8.0legs need Composer's PHPUnit 7.5, so the old-PHP legs swap it in the job.PHPUnit 5.7 requires
symfony/yaml, which every 2.x–4.x release blocks on security advisories. #84975 ignores them.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code