Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84979
October 16, 2026 17:49
This was referenced Oct 16, 2026
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 16, 2026 18:14
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Oct 16, 2026
Open
Open
desrosj
force-pushed
the
fix-actions-5.6/fix-phpunit-dev-dependency-floor
branch
from
October 19, 2026 17:09
cc4cd0c to
f0e2f7d
Compare
desrosj
removed this pull request from stack #84979
October 21, 2026 18:30
desrosj
added this pull request to stack #85319
October 21, 2026 18:30
desrosj
force-pushed
the
fix-actions-5.6/fix-phpunit-dev-dependency-floor
branch
from
October 23, 2026 14:12
f0e2f7d to
36c31c6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82937.
What?
Adds
phpunit/phpunit^7.5(7.5.20) as a dev dependency, and makes thePHP 7.4andPHP 8.0legs ofunit-phprun it instead of their Docker image's PHPUnit. ThePHP 5.6andPHP 7.0legs keep the image's PHPUnit.composer.json: adds the dependency, setsconfig.platform.phpto7.4andrequire.phpto>=5.6.20, and ignoresPKSA-z3gr-8qht-p93vplus foursymfony/yamladvisories (PKSA-v5yj-8nmz-sk2q,PKSA-ft77-7h5f-p3r6,PKSA-b14r-zh1d-vdrc,PKSA-xz3r-9gp4-4m1z).composer.lock:composer update phpunit/phpunit --with-all-dependenciesreplaces the PHPUnit 8.5 thatyoast/phpunit-polyfillspulled in (Repairwp/5.6branch Actions: Pinwp-phpunit/wp-phpunitto the WordPress 5.6 test bootstrap #84974) with 7.5.20. The PHPUnit tree now matcheswp/5.7's andwp/5.8's.unit-test.yml: a job-levelPHPUNITvariable picks the image'sphpuniton PHP 5.6/7.0 andvendor/bin/phpunitotherwise, and both test steps run it throughwp-env run phpunitwith the npm scripts' arguments. A new "Install Composer dependencies" step replaces thecomposer installthose scripts'pretest-*hooks ran.Why?
Both
PHP 8.0legs stop before any test runs:WordPress 5.6's test library (#84974) refuses PHPUnit 8+, the
8.0-fpmimage ships 9.6, and there's no PHPUnit 7 image for PHP 8.0.wordpress-develop's own5.6branch requiresphpunit/phpunit^7.5and runs it on PHP 8. ThePHP 7.4image already ships 7.5.20; that leg uses the Composer copy too, so every PHP 7.2+ leg runs the same PHPUnit.How?
The
wp/5.6version of #84455 (wp/5.8) and #84791 (wp/5.7), with these differences:phpunit/phpunitis added rather than lowered: this branch had no such dependency.platform.phpand therequire.phpfloor are added here; onwp/5.7andwp/5.8they come from Repairwp/5.7branch Actions: Let the current Composer release install this branch's dependencies #84777 and Repairwp/5.8branch Actions: Let the current Composer release install this branch's dependencies #84441. PHPUnit 7.5 requires PHP^7.1, andwp-env'scomposercontainer installs dependencies with its own PHP version regardless ofmatrix.php, so Repairwp/5.6branch Actions: Swapphpunit/phpunitfor a release PHP 5.6 and 7.0 can load #84976 (directly above) swaps the Composer copy on thePHP 5.6andPHP 7.0legs for a release they can load.PKSA-z3gr-8qht-p93v(CVE-2026-24765) covers every PHPUnit below8.5.52, so resolution fails without it. Thesymfony/yamladvisories cover every 2.x–4.x release; nothing installssymfony/yamlfrom this lock, but Repairwp/5.6branch Actions: Swapphpunit/phpunitfor a release PHP 5.6 and 7.0 can load #84976's PHPUnit 5.7 swap on PHP 5.6 needs it. Reasons matchwp/5.7–wp/6.0.Only dev dependencies change; the plugin's
Requires PHP: 5.6stays.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code