Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84979
October 16, 2026 17:49
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 16, 2026 18:09
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Oct 16, 2026
Open
desrosj
force-pushed
the
fix-actions-5.6/fix-phpunit-execution
branch
from
October 19, 2026 17:09
e25ffad to
87636df
Compare
desrosj
removed this pull request from stack #84979
October 21, 2026 18:30
desrosj
added this pull request to stack #85319
October 21, 2026 18:30
desrosj
force-pushed
the
fix-actions-5.6/fix-phpunit-execution
branch
from
October 23, 2026 14:12
87636df to
4ed2817
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82937.
What?
Changes the
wp-phpunit/wp-phpunitconstraint incomposer.jsonfrom^5.4to~5.6.0, and addsyoast/phpunit-polyfills^1.0, which that test library requires.composer.lockmoveswp-phpunit/wp-phpunitfrom5.5.1to5.6.20, the newest5.6.xrelease on Packagist, and addsyoast/phpunit-polyfills1.1.5.Why?
This branch maintains the code as it exists in WordPress 5.6, but
^5.4resolved towp-phpunit/wp-phpunit5.5.1, a copy of WordPress 5.5's test library. The tests ran against the wrong release's test helpers.wp-phpunit/wp-phpunit5.6.6and newer requireyoast/phpunit-polyfills. Without it, every leg stops before any test runs:How?
This is the
wp/5.6version of #84942 (wp/5.8,~5.8.0), #84944 (wp/5.7,~5.7.0), #84413 (wp/5.9) and #84279 (wp/6.0).yoast/phpunit-polyfillsrequiresphpunit/phpunit, and this branch has nophpunit/phpunitdependency yet, so Composer pulls in PHPUnit8.5.56and its dependencies here. #84975, directly above, replaces it with PHPUnit 7.5 and sets the platform PHP version. Every5.6.xrelease still refuses PHPUnit 8 and newer, so on its own this PR doesn't fix thePHP 8.0legs.WordPress 5.6's test library also ships
includes/phpunit7/MockObject/, copies of four PHPUnit 7.5 mock classes patched to avoidReflectionParameter::getClass(), which is deprecated in PHP 8. WordPress Core loads them through its owncomposer.json(autoload-devfiles plusexclude-from-classmapfor PHPUnit's originals).wp-phpunit/wp-phpunitdoesn't register them, and this PR doesn't either:wp/5.7andwp/5.8run PHPUnit 7.5 on PHP 8.0 without them.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code