Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84979
October 16, 2026 17:49
This was referenced Oct 16, 2026
Open
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 16, 2026 18:07
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-5.6/pin-mariadb-version
branch
from
October 19, 2026 17:09
ee56a7f to
a5fa389
Compare
desrosj
removed this pull request from stack #84979
October 21, 2026 18:30
desrosj
added this pull request to stack #85319
October 21, 2026 18:30
desrosj
force-pushed
the
fix-actions-5.6/pin-mariadb-version
branch
from
October 23, 2026 14:12
a5fa389 to
0aa6c75
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82937.
What?
Pins the MariaDB version
wp-envuses in this branch's CI to10.5, by settingWP_ENV_MARIADB_VERSION: '10.5'in the workflow-levelenv:ofend2end-test.ymlandunit-test.yml.Why?
Without a pin,
wp-envruns the floatingmariadb:latestimage: whatever the newest MariaDB release is at the time, many years newer than anything WordPress 5.6 was released against.10.5is the latest MariaDB LTS release that came out before WordPress 5.6, so the database now matches that release's era.How?
Uses the
WP_ENV_MARIADB_VERSIONenvironment variable added in #84970. On this branch that is the only mechanism:wp-envhas nomariadbVersionoption here, and the generated Docker Compose file usesimage: 'mariadb:${WP_ENV_MARIADB_VERSION:-latest}'for both itsmysqlandtests-mysqlservices.wp-envrunsdocker composewithout overriding the environment, so the variable reaches Compose's variable substitution straight from the job environment. A workflow-levelenv:covers every job, including all four End-to-End jobs and every PHP matrix job.Checked with this branch's own
build-docker-compose-config.js: withWP_ENV_MARIADB_VERSION=10.5,docker compose configresolves bothmysqlandtests-mysqltomariadb:10.5(and tomariadb:latestwithout it).The other workflows (
bundle-size.yml,create-block.yml,static-checks.yml) do not runwp-env.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.