Repository navigation
Repair wp/5.6 branch Actions: Fetch react-native-screens as a pre-built tarball - #84968
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
718ebe4 to
4ad5a72
Compare
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
LGTM, thanks! npm ci now passes in every job, so JavaScript goes green. All, Compressed Size, Admin 1-4 and PHP pass further up the stack.
4ad5a72 to
35d17a4
Compare
Part of #82937.
What?
Changes
react-native-screensinpackages/react-native-editor/package.jsonfrom a git dependency (git+https://github.com/wordpress-mobile/react-native-screens.git#b3d907bda2695743f35fd874261dcd27e0912eca) to a pre-built tarball (https://raw.githubusercontent.com/wordpress-mobile/react-native-screens/a25c3d81e0838d57c9f9ac77ef726751e329bad1/react-native-screens-2.9.0-wp-1.tgz), with the two matchingpackage-lock.jsonentries.Why?
npm cifails in "Npm install and build" on every job that installs dependencies, so nothing after it runs. npm has to clone a git dependency and run itspreparescript (bob build), which runstsc. The fork pinstypescript^3.8.3(3.9.x) but not@types/node, sotscpicks up the current@types/node, whose syntax needs TypeScript 4.0–4.5, and fails withTS1005/TS1109/TS1110errors.A tarball ships with
lib/already built, sopreparenever runs.wp/5.9already uses this exact tarball.How?
The tarball is built from wordpress-mobile/react-native-screens@a25c3d8, a descendant of the currently pinned wordpress-mobile/react-native-screens@b3d907b. Between the two commits
src/is byte-identical; only Android/Gradle tooling (android/build.gradle, the Gradle wrapper,RNScreens.podspec) and the version string (2.9.0→2.9.0-wp-1) change. So this is a packaging change, not a behavior change.The tarball's SHA-512 matches the
integrityinwp/5.9'spackage-lock.json(sha512-6u4uqEweGAr/nSEM5FOrQ3TH1YrqGHlystnCu3LSJnvhdbfunxPQMUIRHyvWjukPamHPNzqxSJDzdUTI3D2/CA==), and it contains builtlib/commonjs,lib/moduleandlib/typescript. The other git dependencies with a TypeScriptpreparebuild (react-native-safe-area-context,react-native-svg) don't hit the same failure.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.