Skip to content

Repair wp/5.6 branch Actions: Ignore the stale Browserslist data warning in unit tests - #84967

Open
desrosj wants to merge 1 commit into
fix-actions-5.6/configure-composer-advisory-policyfrom
fix-actions-5.6/ignore-browserslist-old-data
Open

desrosj wants to merge 1 commit into
fix-actions-5.6/configure-composer-advisory-policyfrom
fix-actions-5.6/ignore-browserslist-old-data

Conversation

@desrosj

@desrosj desrosj commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Part of #82937.

What?

Sets BROWSERSLIST_IGNORE_OLD_DATA=true before Jest boots, in test/unit/jest.config.js.

Why?

test/unit/jest.config.js uses @wordpress/jest-preset-default, whose @wordpress/jest-console assertions fail any test that logs a warning. packages/babel-preset-default and packages/browserslist-config log "Browserslist: caniuse-lite is outdated" during the run, so the JavaScript job fails two suites:

FAIL packages/babel-preset-default/test/index.js
  ● Babel preset default › transpilation works properly
FAIL packages/browserslist-config/test/index.test.js
  ● should not contain invalid queries

    expect(jest.fn()).not.toHaveWarned(expected)
    ["Browserslist: caniuse-lite is outdated. Please run:
    npx browserslist@latest --update-db"]

This branch pins browserslist@4.14.0 and an equally old caniuse-lite. The warning depends on the data's age against today's date, so it will keep appearing on a frozen branch regardless of code changes.

At this point in the stack the job stops earlier, at the npm ci failure fixed by #84968; the warning failure shows once that's fixed.

How?

Ports wp/7.0's a468930 ("Tests: Ignore Browserslist old data warning in unit tests"). It doesn't cherry-pick cleanly because this branch's config has no process.env.TZ line to anchor to, so the line goes after the transpiledPackageNames block, as on wp/5.9 (#84408) and wp/6.0 (#84275).

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 16, 2026
@desrosj desrosj self-assigned this Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8dac88bc-91fa-406f-ae09-cf5d83a454a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj changed the title Repair wp/5.6 branch Actions: Ignore Browserslist old-data warning in unit tests Repair wp/5.6 branch Actions: Ignore the stale Browserslist data warning in unit tests Oct 16, 2026
@desrosj
desrosj force-pushed the fix-actions-5.6/ignore-browserslist-old-data branch from 291c4fb to 4e6aa2c Compare October 19, 2026 17:09

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch PR Browserslist Base PR, JS unit This PR, JS unit
5.6 #84967 4.10.0–4.14.0 npm ci fails before tests same (fixed by row AG, #84968)

@desrosj
desrosj removed this pull request from stack #84979 October 21, 2026 18:30
@desrosj
desrosj added this pull request to stack #85319 October 21, 2026 18:30
@desrosj
desrosj force-pushed the fix-actions-5.6/ignore-browserslist-old-data branch from 4e6aa2c to ca4079c Compare October 23, 2026 14:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants