Repository navigation
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tellthemachines. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
0a43b18 to
6caf464
Compare
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
🙀 that we had these running after every test!
Makes sense to remove.
|
Note we also have toPassAxeTests on this branch which I don't believe is called anywhere else. Probably not worth removing though. |
Confirmed that it's not being called anywhere. Agreed that leaving it as is would be totally fine. |
Part of #82937.
What?
Removes the global
afterEachAxe accessibility scan frompackages/e2e-tests/config/setup-test-framework.js: therunAxeTestsForBlockEditor()function and its call. This is a hand port of #26626 (39fe8d6), which removed the same hook on trunk in Gutenberg 9.7.wp/5.7and every newer branch already have that change.Why?
After every test, the hook scans the editor with Axe and fails the test on any violation, even when the test itself passed. On this branch the two "should strip potentially malicious on* attributes" tests (
missing.test.jsandinvalid-block.test.js) fail on theimage-altrule. They came with the 2021-09-08 security backport "Rich text: disable some attributes" (49a979f) and deliberately put<img src onerror=alert(1)>in the post to check that theonerrorhandler doesn't run. The tests pass, but the image they leave has no alt text, so the scan that runs afterwards fails them. The scan also failsnew editor state › should be immediately saveable(demo.test.js) when it tries to inject axe-core into an iframe in the demo post that is still loading (Failed to inject axe-core into frame (about:blank)), which is flaky. These three tests are the only end-to-end failures on this branch.On trunk, #26626 removed the scan because its list of disabled rules kept growing to get CI green, and some of its reports were Axe bugs; it also made the end-to-end tests 2–4 minutes faster.
How?
The same deletion as #26626, applied by hand because this branch's version of the file differs (its list of disabled rules is shorter). No lines are added.
Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code