Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
changed the title
wp/5.6 branch Actions: Always read Node.js version from .nvmrc filewp/5.6 branch Actions: Always read the Node.js version from .nvmrc
Part of #82937.
What?
Replaces the hardcoded
node-version: 12.xliteral on everyactions/setup-nodestep acrosswp/5.6's workflows withnode-version-file: '.nvmrc', so.nvmrcbecomes the one source of truth for the Node.js version this branch tests against — all 9 occurrences across five workflows:bundle-size.ymlbuildcreate-block.ymlbuildend2end-test.ymladmin-1,admin-2,admin-3,admin-4static-checks.ymlcheckunit-test.ymlunit-js,unit-phpBecause each step's
namealso carried the version (Use Node.js 12.x), it is renamed toSetup Node.jsin the same commit — leaving the version in the name would reintroduce exactly the duplication this change removes.The
mobile-unit-jsjob's setup step isn't included: that job is removed earlier in this stack (#84957).No functional change.
.nvmrcreads12at this point in the stack, the same version the literals pinned, so every affected job resolves to the same Node.js version as before; only the mechanism changes. Each workflow is a separate commit.Why?
Without this, every Node.js version change on this branch means editing 9 hardcoded literals and 9 step names across five files, which can silently drift apart from
.nvmrcand from each other. With it, a version change is a one-line edit to.nvmrc: the Node.js 12 → 14 upgrade later in this stack (#84960) only changes.nvmrc.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.