Repository navigation
Refactor(e2e): Convert remaining utilities to TS - #84917
Merged
manzoorwanijk merged 4 commits intoOct 23, 2026
Merged
manzoorwanijk merged 4 commits into
manzoorwanijk merged 4 commits into
Conversation
github-actions
Bot
added
the
[Tool] E2E Test Utils
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the |
USERSATOSHI
marked this pull request as ready for review
October 17, 2026 10:22
manzoorwanijk
added
the
[Type] Code Quality
manzoorwanijk
requested changes
Oct 21, 2026
manzoorwanijk
approved these changes
Oct 23, 2026
manzoorwanijk
left a comment
manzoorwanijk
left a comment
Member
There was a problem hiding this comment.
This branch needs to be updated from trunk.
USERSATOSHI
force-pushed
the
refactor/playwright-utils-typescript
branch
from
October 23, 2026 11:46
11a496a to
806da31
Compare
manzoorwanijk
added
the
props-bot
github-actions
Bot
removed
the
props-bot
manzoorwanijk
enabled auto-merge (squash)
October 23, 2026 11:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #67691.
Convert
set-browser-viewport.jsandrequest-utils/widgets.jsin@wordpress/e2e-test-utils-playwrightto TypeScript.Why?
Complete the package's TypeScript source migration.
How?
Add explicit types, convert existing comments to TSDoc, preserve legacy viewport type aliases, and remove redundant TypeScript configuration overrides. No runtime changes.
Testing Instructions
Run
npm run build,npm run typecheck, andnpm run lint:js.Then run:
Use of AI Tools
OpenAI Codex assisted with testing, and validation. I reviewed and updated the changes myself.