Repository navigation
Repair wp/5.7 branch Actions: Only read the template slug when a template exists in the templates REST controller - #84795
Open
desrosj wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84797
October 15, 2026 03:46
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84797
October 16, 2026 00:33
desrosj
force-pushed
the
fix-actions-5.7/fix-templates-controller-null-template
branch
from
October 16, 2026 00:33
c14781e to
58564df
Compare
desrosj
added this pull request to stack #84872
October 16, 2026 00:34
desrosj
marked this pull request as ready for review
October 16, 2026 01:18
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84872
October 16, 2026 15:52
desrosj
force-pushed
the
fix-actions-5.7/fix-templates-controller-null-template
branch
from
October 16, 2026 15:52
58564df to
360b0b2
Compare
desrosj
added this pull request to stack #84945
October 16, 2026 15:53
desrosj
force-pushed
the
fix-actions-5.7/fix-templates-controller-null-template
branch
from
October 19, 2026 17:09
360b0b2 to
9a23e46
Compare
andrewserong
approved these changes
Oct 20, 2026
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
The change looks good to me! Just left an optional nit about if we should also roll in one other detail from the PR this hand cherry-picks.
Since these fixes are about ensuring the overall release can still pass automated testing, the comment is entirely optional, and I think this PR would be fine to land either way.
desrosj
removed this pull request from stack #84945
October 21, 2026 19:48
desrosj
added this pull request to stack #85354
October 21, 2026 19:48
… in the templates REST controller.
desrosj
force-pushed
the
fix-actions-5.7/fix-templates-controller-null-template
branch
from
October 23, 2026 13:59
c88e72b to
9f91cbe
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82936.
What?
In
WP_REST_Templates_Controller::prepare_item_for_database():$changes->post_name = $template->sluginto the two branches where$templateexists.themeparameter, sets thewp_themeterm from$request['theme']instead of$request['content'].Why?
When a template is created,
$templateisnull, and the method reads$template->slugbefore checking for that. On PHP 8 this is a warning, sotest_create_itemfails on thePHP 8.0jobs:These endpoints first shipped in WordPress 5.8. On this branch they exist only as plugin code in
lib/, which isn't in any npm package and never reaches a WordPress 5.7 release. A small change here keeps the tests green, so security fixes for the packages WordPress 5.7 does ship can be verified reliably.How?
This is the same change as 046c82f (#32176), applied by hand because that commit doesn't cherry-pick here. Updates still set
post_namefrom the template, andcreate_item()already sets it from the request.The
wp_themefix was suggested in review. The tests don't cover it:test_create_itemdoesn't passtheme, and nothing in the editor on this branch sends it. Before this change, a request that did would have assigned the template's content as its theme, leaving the new template unreachable.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code