Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84797
October 15, 2026 03:46
This was referenced Oct 15, 2026
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84797
October 16, 2026 00:33
desrosj
force-pushed
the
fix-actions-5.7/fix-phpunit-dev-dependency-floor
branch
from
October 16, 2026 00:33
a66c107 to
5954bdc
Compare
desrosj
added this pull request to stack #84872
October 16, 2026 00:34
desrosj
marked this pull request as ready for review
October 16, 2026 01:21
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84872
October 16, 2026 15:52
desrosj
force-pushed
the
fix-actions-5.7/fix-phpunit-dev-dependency-floor
branch
from
October 16, 2026 15:52
5954bdc to
b573945
Compare
desrosj
changed the base branch from
fix-actions-5.7/fix-site-editor-save-flow-outline-button
to
fix-actions-5.7/fix-phpunit-execution
October 16, 2026 15:53
desrosj
added this pull request to stack #84945
October 16, 2026 15:53
This was referenced Oct 16, 2026
Open
desrosj
force-pushed
the
fix-actions-5.7/fix-phpunit-dev-dependency-floor
branch
from
October 19, 2026 17:09
b573945 to
166189c
Compare
desrosj
removed this pull request from stack #84945
October 21, 2026 19:48
desrosj
added this pull request to stack #85354
October 21, 2026 19:48
desrosj
force-pushed
the
fix-actions-5.7/fix-phpunit-dev-dependency-floor
branch
from
October 23, 2026 13:59
166189c to
27a0ad8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82936.
What?
Lowers
phpunit/phpunitfrom^8.5to^7.5(7.5.20), and makes thePHP 7.4andPHP 8.0jobs run that Composer-installed PHPUnit instead of the one bundled in their Docker image.composer.json: lowers the constraint and ignores advisoriesPKSA-z3gr-8qht-p93v,PKSA-v5yj-8nmz-sk2q,PKSA-ft77-7h5f-p3r6,PKSA-b14r-zh1d-vdrcandPKSA-xz3r-9gp4-4m1z.composer.lock: regenerated withcomposer update phpunit/phpunit --with-dependencies. Only PHPUnit's dependency tree changes.unit-test.yml: a job-levelPHPUNITvariable holds the image'sphpunitfor PHP 5.6/7.0, andvendor/bin/phpunitotherwise. Both test steps use it.Why?
The
PHP 7.4andPHP 8.0jobs stop before any test runs:The locked
wp-phpunit/wp-phpunit5.7.18(#84944, directly below) refuses PHPUnit 8 and newer, but the images ship PHPUnit 8.5 (PHP 7.4) and 9.6 (PHP 8.0), and there's no PHPUnit 7 image for PHP 8.0. WordPress Core handles its 5.8 and older branches the same way, installing PHPUnit 7.5 with Composer.Upgrading
wp-phpunit/wp-phpunitto5.9.x, whose test library accepts PHPUnit 8 and 9, would mean running a newer release's test library against WordPress 5.7.How?
This is the same change as
wp/5.8's #84455:PKSA-z3gr-8qht-p93vcovers every PHPUnit release below8.5.52, so resolution fails without the ignore. It uses the same reason aswp/5.8–wp/6.0.PKSA-v5yj-8nmz-sk2q,PKSA-ft77-7h5f-p3r6,PKSA-b14r-zh1d-vdrcandPKSA-xz3r-9gp4-4m1zmatch everysymfony/yaml2.x–4.x release. Nothing installssymfony/yamlfrom this lock, but thePHP 5.6legs swap in PHPUnit 5.7 (Repairwp/5.7branch Actions: Swapphpunit/phpunitfor a release PHP 5.6 and 7.0 can load #84774, earlier in this stack), which requires it, and resolution fails without them. The first three usewp/5.9's reasons.PKSA-xz3r-9gp4-4m1z(CVE-2026-109413) was published on 2026-08-30, afterwp/5.9's list was written, and gets the same kind of reason.With this change, the
PHP 8.0jobs reachREST_Widgets_Controller_Test::test_get_items, which hangs on PHP 8 with WordPress 5.7. #84792, directly above this PR, skips that test.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code