Repository navigation
Repair wp/5.7 branch Actions: Use the Outline dropdown in the Site Editor save flow e2e test - #84790
Open
desrosj wants to merge 1 commit into
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84797
October 15, 2026 03:46
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84797
October 16, 2026 00:33
desrosj
force-pushed
the
fix-actions-5.7/fix-site-editor-save-flow-outline-button
branch
from
October 16, 2026 00:33
ad4a15f to
fb322b6
Compare
desrosj
added this pull request to stack #84872
October 16, 2026 00:34
desrosj
marked this pull request as ready for review
October 16, 2026 01:21
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84872
October 16, 2026 15:52
desrosj
force-pushed
the
fix-actions-5.7/fix-site-editor-save-flow-outline-button
branch
from
October 16, 2026 15:52
fb322b6 to
dfbba25
Compare
desrosj
added this pull request to stack #84945
October 16, 2026 15:53
desrosj
force-pushed
the
fix-actions-5.7/fix-site-editor-save-flow-outline-button
branch
from
October 19, 2026 17:09
dfbba25 to
ef3f903
Compare
desrosj
removed this pull request from stack #84945
October 21, 2026 19:48
desrosj
added this pull request to stack #85354
October 21, 2026 19:48
andrewserong
approved these changes
Oct 23, 2026
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
LGTM! And confirmed manually in Playground that "Outline" is the aria-label in 5.7:
desrosj
force-pushed
the
fix-actions-5.7/fix-site-editor-save-flow-outline-button
branch
from
October 23, 2026 13:59
ef3f903 to
d220f54
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82936.
What?
Updates the Site Editor "Save flow should work as expected" end-to-end test in
packages/e2e-tests/specs/experiments/multi-entity-saving.test.jsto select the header template part through Gutenberg 9.9's "Outline" block navigation dropdown.Why?
The test step came to
wp/5.7with the backport of #29920 (6627d6a) in #30528. On trunk, that PR changed the test to select the template part from the List View sidebar, because clicking the block itself could hit the inserter between the template part's columns.wp/5.7is Gutenberg 9.9, which has no List View sidebar: its block list is a dropdown under a toolbar button labelled "Outline". The test waits forbutton[aria-label="List View"], which never appears, so it fails on every run (Admin - 4).The product change from #29920 is still correct for this branch: the double inserter it fixes came from #28418, which is in Gutenberg 9.9.
How?
button[aria-label="Outline"]instead ofbutton[aria-label="List View"], as the other 5.7 tests do (columns.test.js,block-hierarchy-navigation.test.js,reusable-blocks.test.js).Using custom components as toolbar controls is deprecatedwarning, as the earlier test in this file already does. Selecting the template part shows its block toolbar, whose text field Gutenberg 9.9 still renders as a custom toolbar control, so the console check after the test otherwise fails (Admin - 4).Only
wp/5.7is affected:wp/5.8andwp/5.9have the List View sidebar, and thewp/5.6andwp/5.5versions of this test don't use it.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code