Repository navigation
Repair wp/5.7 branch Actions: Omit WordPress dependencies when scaffolding in the Create Block check - #84787
Open
desrosj wants to merge 1 commit into
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84797
October 15, 2026 03:46
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 15, 2026 19:10
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84797
October 16, 2026 00:33
desrosj
added this pull request to stack #84872
October 16, 2026 00:34
desrosj
removed this pull request from stack #84872
October 16, 2026 15:52
desrosj
force-pushed
the
fix-actions-5.7/fix-create-block-wp-dependencies
branch
from
October 16, 2026 15:52
2d56c7a to
32e8317
Compare
desrosj
added this pull request to stack #84945
October 16, 2026 15:53
desrosj
force-pushed
the
fix-actions-5.7/fix-create-block-wp-dependencies
branch
from
October 19, 2026 17:09
32e8317 to
e37fc43
Compare
desrosj
removed this pull request from stack #84945
October 21, 2026 19:48
desrosj
added this pull request to stack #85354
October 21, 2026 19:48
ntsekouras
approved these changes
Oct 22, 2026
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Scaffolding no longer installs the latest @wordpress/* packages, so the Create Block check passes on Node.js 14.
desrosj
force-pushed
the
fix-actions-5.7/fix-create-block-wp-dependencies
branch
from
October 23, 2026 13:59
e37fc43 to
582b7c0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82936.
What?
Ports the parts of #37639 (2294dee) that the Create Block check needs, so
@wordpress/create-blockno longer installs the latest@wordpress/block-editor,@wordpress/blocksand@wordpress/i18nreleases when scaffolding a block:esnexttemplate and@wordpress/create-block-tutorial-templateno longer listnpmDependencies.packages/create-block/lib/init-package-json.jsonly installs a template'snpmDependencieswhenwp-scriptsis being set up.@wordpress/eslint-plugin'srecommended-with-formattingconfig ignores@wordpress/*imports (other thaniconsandinterface) forimport/no-unresolvedand marks them as internal, and the root.eslintrc.jssetsimport/internal-regextonullso the repository's own lint rules are unchanged.Why?
The Create Block check (
bin/test-create-block.sh) fails on every run on this branch. Scaffolding installs the newest releases of those packages, which now require Node.js 18.12 or newer. This branch runs Node.js 14 withengine-strict = true, so every install fails, and linting the scaffolded block then fails withimport/no-unresolvedon the three imports.How?
The trunk commit doesn't cherry-pick onto this branch:
.eslintrc.jsand several@wordpress/eslint-pluginconfigs have changed since. The changes above were applied by hand. The trunk commit's other edits to@wordpress/eslint-plugin(React version detection inreact.js, and moving settings out ofcustom.jsandrecommended.js) aren't needed to fix this and are left out, as are its CHANGELOG entries.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code