Repository navigation
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84797
October 15, 2026 03:46
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 15, 2026 19:08
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84797
October 16, 2026 00:33
desrosj
added this pull request to stack #84872
October 16, 2026 00:34
desrosj
removed this pull request from stack #84872
October 16, 2026 15:52
desrosj
force-pushed
the
fix-actions-5.7/fix-bundle-size-node-version
branch
from
October 16, 2026 15:52
54aee23 to
cd69e45
Compare
desrosj
added this pull request to stack #84945
October 16, 2026 15:53
desrosj
changed the title
wp/5.7 branch Actions: Pin Node.js version in the Compressed Size workflowwp/5.7 branch Actions: Pin the Node.js version in the Compressed Size workflow
desrosj
force-pushed
the
fix-actions-5.7/fix-bundle-size-node-version
branch
from
October 19, 2026 17:09
cd69e45 to
435b268
Compare
ntsekouras
approved these changes
Oct 21, 2026
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Compressed Size now installs and builds on the branch's Node 14 instead of the runner's Node 22, and passes.
desrosj
removed this pull request from stack #84945
October 21, 2026 19:48
desrosj
added this pull request to stack #85354
October 21, 2026 19:48
desrosj
force-pushed
the
fix-actions-5.7/fix-bundle-size-node-version
branch
from
October 23, 2026 13:59
435b268 to
9c97304
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82936.
What?
Adds a
Setup Node.js(actions/setup-node,node-version-file: '.nvmrc') step tobundle-size.yml'sCheckjob, beforepreactjs/compressed-size-action, matching the step every other workflow on this branch already uses.Why?
preactjs/compressed-size-actionruns its ownnpm cifor the PR's head and base commits with whatever Node.js the runner provides when noactions/setup-nodestep comes first. Onubuntu-24.04that is Node.js 22, and the install fails inreact-native-svg@9.13.6-gb's git-dependencypreparescript (flowgen→bob):This branch's
.nvmrcis14, which every other job uses for its ownnpm ci, and those jobs install the same dependency without this error.wp/5.7'sbundle-size.ymlnever had a Node.js step: its last upstream change (Gutenberg 9.6, December 2020) only bumpedcompressed-size-action.wp/5.6got one through the WP 5.6.2 backports (#29058), andwp/5.8and newer have one too.How?
Same change as
wp/5.5's #85007.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code