Skip to content

Repair wp/5.7 branch Actions: Fix theme-activation navigation race in activate-theme.js - #84780

Open
desrosj wants to merge 1 commit into
fix-actions-5.7/ignore-browserslist-old-datafrom
fix-actions-5.7/fix-activate-theme-navigation-race
Open

Repair wp/5.7 branch Actions: Fix theme-activation navigation race in activate-theme.js#84780
desrosj wants to merge 1 commit into
fix-actions-5.7/ignore-browserslist-old-datafrom
fix-actions-5.7/fix-activate-theme-navigation-race

Conversation

@desrosj

@desrosj desrosj commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82936.

What?

In the Puppeteer activateTheme() helper (packages/e2e-test-utils/src/activate-theme.js), wait for the navigation triggered by clicking "Activate" before checking that the theme is active, and give that check a 45s timeout.

Why?

Clicking "Activate" loads a new page (theme switch, then a redirect back to themes.php). Without waiting for it, the single waitForSelector() call has to cover that whole round trip within Puppeteer's default 30s and can time out:

TimeoutError: waiting for selector `div[data-slug="..."].active` failed: timeout 30000ms exceeded

This race repeatedly failed CI on wp/6.5 and wp/6.4, where #83002 and #83686 fix it. It has not failed on this branch yet, so this is included proactively to keep the helper identical across branches.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added [Type] Build Tooling Issues or PRs related to build tooling [Tool] Env /packages/env labels Oct 15, 2026
@desrosj desrosj self-assigned this Oct 15, 2026
@github-actions github-actions Bot removed the [Tool] Env /packages/env label Oct 15, 2026
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9811b834-1045-4ac6-a211-12883aa9fad5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj added this pull request to stack #84797 October 15, 2026 03:46
This was referenced Oct 15, 2026
Open
Closed
Open
@desrosj
desrosj removed this pull request from stack #84797 October 16, 2026 00:33
@desrosj
desrosj added this pull request to stack #84872 October 16, 2026 00:34
@desrosj
desrosj marked this pull request as ready for review October 16, 2026 01:23
@github-actions

github-actions Bot commented Oct 16, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #84872 October 16, 2026 15:52
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-activate-theme-navigation-race branch from 50ca1dd to ad8ebce Compare October 16, 2026 15:52
@desrosj
desrosj added this pull request to stack #84945 October 16, 2026 15:53
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-activate-theme-navigation-race branch from ad8ebce to b361c21 Compare October 19, 2026 17:09
@desrosj
desrosj removed this pull request from stack #84945 October 21, 2026 19:48
@desrosj
desrosj added this pull request to stack #85354 October 21, 2026 19:48
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-activate-theme-navigation-race branch from b361c21 to 087768b Compare October 23, 2026 13:59
ntsekouras
ntsekouras approved these changes Oct 25, 2026
View reviewed changes

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

Assignees

@desrosj desrosj

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ntsekouras