Repository navigation
Repair wp/5.7 branch Actions: Let the current Composer release install this branch's dependencies - #84777
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wp/5.7 branch Actions: Run PHP coding standards on the runner instead of inside wp-env
#84775
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2f35569 to
65aab42
Compare
desrosj
changed the title
wp/5.7 branch Actions: Run the newest Composer against a declared PHP versionwp/5.7 branch Actions: Let the current Composer release install this branch's dependencies
65aab42 to
10cf2d5
Compare
Part of #82936.
What?
Three changes, one commit each:
config.allow-pluginsfor the two Composer plugins this repository uses.config.platform.phpas7.4andrequire.phpas>=5.6.20, and regeneratescomposer.lockto match.wp-env'scomposerservice to thecomposer:2image instead of the floatingcomposerimage (packages/env/lib/build-docker-compose-config.js), with apackages/env/CHANGELOG.mdentry.Why?
allow-plugins: Composer 2.2+ requires plugins to be explicitly allowed. Older Composer only warned, but current Composer fails withcomposer/installers contains a Composer plugin which is blocked by your allow-plugins config. That breaks theInstall a PHPUnit release this PHP version can loadstep from #84774 and thephpcsjob'scomposer installfrom #84775.--no-pluginsisn't a workaround, becausedealerdirect/phpcodesniffer-composer-installeris the plugin that registers the PHPCS standards.platform.php: The lock was resolved for PHP 7.4 but didn't record it, so Composer checked it against the container's PHP (8.5) and refused to installphpspec/prophecy 1.12.2(requires php ^7.2 || ~8.0, <8.1). Declaring the platform makes the lock install the same way at any container PHP.7.4satisfies every locked package and matches the PHP version thephpcsjob uses.require.phprecords WordPress's minimum PHP version as the project's floor.The lock was regenerated with
composer update --lock, so no package versions changed. The only differences are the platform fields, thecontent-hash,plugin-api-version, some empty[]written as{}, and thesquizlabs/php_codesnifferURLs now pointing toPHPCSStandards(same release and commit).composer:2: The image is pinned tocomposer:2rather than an exact release.composer:2still gets every Composer 2 release, including security fixes, but a future Composer 3 can't change how this branch installs its dependencies until someone updates the tag. The PHP version inside the image still follows the tag (PHP 8.5 today); that doesn't change which packages get installed, becausecomposer.lockdecides that.Testing Instructions
In the
composerimage (Composer 2.10.3, PHP 8.5.10).composer:2is currently the same image as the floatingcomposerimage, so these results apply to it.composer install20vendor/bin/phpcs -iPHPCompatibility,VariableAnalysisand theWordPressstandardsUse of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code