Skip to content

Repair wp/5.7 branch Actions: Skip installing Xdebug in wp-env when it is off - #84776

Open
desrosj wants to merge 1 commit into
fix-actions-5.7/run-phpcs-on-runnerfrom
fix-actions-5.7/fix-xdebug-pecl-php7
Open

Repair wp/5.7 branch Actions: Skip installing Xdebug in wp-env when it is off#84776
desrosj wants to merge 1 commit into
fix-actions-5.7/run-phpcs-on-runnerfrom
fix-actions-5.7/fix-xdebug-pecl-php7

Conversation

@desrosj

@desrosj desrosj commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #82936.

What?

Makes wp-env's generated Dockerfile skip the Xdebug install block entirely when Xdebug is off (xdebugMode === 'off'), in packages/env/lib/init-config.js. Adds a packages/env changelog entry.

Why?

dockerFileContents() ran pecl install xdebug unconditionally, whatever xdebugMode the caller passed. With no version pin, pecl install xdebug resolves to the newest Xdebug release, which requires PHP >= 8.0. Every wp-env start for a PHP version below that (5.6, 7.0 and 7.4 in this branch's test matrix) failed the Docker build before the site could start:

pecl/xdebug requires PHP (version >= 8.0.0, version <= 8.5.99), installed version is 5.6.39

Xdebug is off for every CI job on this branch (no --xdebug flag is passed to wp-env start), so skipping the install when it's off removes the failure without tracking which Xdebug version supports which PHP version. Newer @wordpress/env releases also only install Xdebug when it's requested.

How?

wp/5.8 fixes the same failure differently (#84446): it pins xdebug-3.1.6 on PHP 7, because its wp-env installs Xdebug on PHP 7.2 and newer regardless of the mode.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj added [Type] Build Tooling Issues or PRs related to build tooling [Tool] Env /packages/env labels Oct 15, 2026
@desrosj desrosj self-assigned this Oct 15, 2026
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c6addd3e-f1d5-4d3e-a4e7-5f5321f019a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj added this pull request to stack #84797 October 15, 2026 03:46
This was referenced Oct 15, 2026
Open
Closed
Open
@desrosj
desrosj marked this pull request as ready for review October 15, 2026 19:07
@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #84797 October 16, 2026 00:33
@desrosj
desrosj added this pull request to stack #84872 October 16, 2026 00:34
@desrosj
desrosj removed this pull request from stack #84872 October 16, 2026 15:52
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-xdebug-pecl-php7 branch from 407715f to dfb1a17 Compare October 16, 2026 15:52
@desrosj
desrosj added this pull request to stack #84945 October 16, 2026 15:53
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-xdebug-pecl-php7 branch from dfb1a17 to a5a314e Compare October 19, 2026 17:09
@desrosj
desrosj removed this pull request from stack #84945 October 21, 2026 19:48
@desrosj
desrosj added this pull request to stack #85354 October 21, 2026 19:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

Assignees

@desrosj desrosj

Labels

[Tool] Env /packages/env [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @ntsekouras