Repository navigation
Repair wp/5.7 branch Actions: Run PHP coding standards on the runner instead of inside wp-env - #84775
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
0f92ece to
a295ac0
Compare
a295ac0 to
fbf1bc8
Compare
Part of #82936.
What?
Moves PHP coding standards checks (
phpcs) out ofwp-envinto a newphpcsjob inunit-test.yml. The job runs on the runner at PHP 7.4, reports violations as annotations withcs2pr, and checks that no version-controlled files changed. The.cache/.gitkeep,.gitignoreandphpcs.xml.distchanges add the PHPCS scan cache. It also setstimeout-minutes: 20on the newphpcsjob, like the other jobs got in #84763.In the PHPUnit job, the
Running lint checkstep is replaced by anInstall Composer dependenciesstep (npm run wp-env run composer "install --no-interaction").Why?
Coding standards checks don't depend on the PHP version being tested. Inside
wp-envthey only ran after the environment started, they repeated on every leg of the PHP matrix added in #84772, and violations showed up as container logs instead of annotations on the diff.The lint step's
prelint-phphook was also the only thing that installed Composer dependencies for PHPUnit, andphpunit/bootstrap.phprequiresvendor/autoload.php.wp-env startdoesn't install them on this branch, so the new step keeps that install.The job uses PHP 7.4 because the PHP_CodeSniffer and WPCS releases this branch depends on emit deprecation notices on PHP 8.4 and newer that abort the scan.
How?
Ports the
phpcsjob from #46510 (9ee17a7).The
phpcscommand keeps--runtime-set ignore_warnings_on_exit 1from this branch's Composerlintscript, so existing warnings are still reported but don't fail the job, as before.Both Composer installs fail until #84777 (two PRs up) adds
config.allow-pluginsandconfig.platform.php.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code